-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cli): exit 1 when compilation fail #2650
Conversation
WalkthroughThe changes involve enhancements to the compilation process within the CLI package. A new console log statement has been introduced to inform users about the success or failure of the compilation. The Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (1)
packages/cli/lib/services/compile.service.ts (1)
70-71
: Review the usage ofcompileAllFiles
to ensure consistency with the new signature.The
compileAllFiles
function is called in several places without thescriptName
parameter, which may lead to issues if the function expects it to be defined. Please review the following instances to ensure correct usage:
packages/cli/lib/index.ts
: Line 70packages/cli/lib/services/verification.service.ts
: Lines 70, 75, 80packages/cli/lib/cli.ts
: Line 70packages/cli/lib/services/deploy.service.ts
: Lines 70, 75Ensure that the
scriptName
parameter is included where necessary to avoid potential issues.Analysis chain
LGTM! But verify the function usage in the codebase.
The changes enhance the control flow by explicitly handling the case where
scriptName
is undefined, ensuring that the function behaves predictably in such scenarios.The code changes are approved.
Run the following script to verify the function usage:
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all function calls to `compileAllFiles` match the new signature. # Test: Search for the function usage. Expect: Only occurrences of the new signature. rg --type ts -A 5 $'compileAllFiles'Length of output: 10607
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- packages/cli/lib/index.ts (1 hunks)
- packages/cli/lib/services/compile.service.ts (2 hunks)
Additional comments not posted (2)
packages/cli/lib/services/compile.service.ts (1)
Line range hint
237-237
: LGTM!The formatting change improves the code's readability without altering the logic.
The code changes are approved.
packages/cli/lib/index.ts (1)
237-237
: LGTM!The new console log statement enhances user experience by providing clearer feedback on the compilation status, which may help in troubleshooting issues related to file compilation.
The code changes are approved.
Describe your changes
Fixes https://linear.app/nango/issue/NAN-1622/github-actions-doesnt-fail-on-compilation-error
nango compile
Summary by CodeRabbit
New Features
Bug Fixes
scriptName
in the compilation logic to prevent unexpected failures.Refactor