fix: action and webhook logs improvements

packages/jobs/lib/execution/action.ts

@@ -105,11 +105,6 @@ export async function startAction(task: TaskAction): Promise<Result<void>> {
     }
 }
 export async function handleActionSuccess({ nangoProps }: { nangoProps: NangoProps }): Promise<void> {
-    const logCtx = await logContextGetter.get({ id: String(nangoProps.activityLogId) });
-    const content = `${nangoProps.syncConfig.sync_name} action was run successfully and results are being sent synchronously.`;
-
-    await logCtx.info(content);
-
     const connection: NangoConnection = {
         id: nangoProps.nangoConnectionId!,
         connection_id: nangoProps.connectionId,
@@ -219,5 +214,4 @@ async function onFailure({
             }
         });
     }
-    await logCtx.error(error.message, { error });
 }

packages/jobs/lib/execution/postConnection.ts

@@ -121,7 +121,6 @@ export async function handlePostConnectionSuccess({ nangoProps }: { nangoProps:
         createdAt: Date.now()
     });
     const logCtx = await logContextGetter.get({ id: String(nangoProps.activityLogId) });
-    await logCtx.info(content);
     await logCtx.success();
 }
 

packages/jobs/lib/execution/webhook.ts

@@ -122,7 +122,6 @@ export async function startWebhook(task: TaskWebhook): Promise<Result<void>> {
             syncName: task.parentSyncName,
             syncJobId: syncJob?.id,
             providerConfigKey: task.connection.provider_config_key,
-            activityLogId: task.activityLogId,
             runTime: 0,
             error,
             environment: { id: task.connection.environment_id, name: environment?.name || 'unknown' },
@@ -151,8 +150,6 @@ export async function handleWebhookSuccess({ nangoProps }: { nangoProps: NangoPr
         runTimeInSeconds: (new Date().getTime() - nangoProps.startedAt.getTime()) / 1000,
         createdAt: Date.now()
     });
-    const logCtx = await logContextGetter.get({ id: String(nangoProps.activityLogId) });
-    await logCtx.info(content);
 
     await updateSyncJobStatus(nangoProps.syncJobId!, SyncStatus.SUCCESS);
 }
@@ -169,7 +166,6 @@ export async function handleWebhookError({ nangoProps, error }: { nangoProps: Na
         syncName: nangoProps.syncConfig.sync_name,
         syncJobId: nangoProps.syncJobId!,
         providerConfigKey: nangoProps.providerConfigKey,
-        activityLogId: nangoProps.activityLogId!,
         runTime: (new Date().getTime() - nangoProps.startedAt.getTime()) / 1000,
         error,
         environment: { id: nangoProps.environmentId, name: nangoProps.environmentName || 'unknown' },
@@ -185,7 +181,6 @@ async function onFailure({
     syncName,
     syncJobId,
     providerConfigKey,
-    activityLogId,
     runTime,
     error
 }: {
@@ -196,7 +191,6 @@ async function onFailure({
     syncJobId?: number | undefined;
     syncName: string;
     providerConfigKey: string;
-    activityLogId: string;
     runTime: number;
     error: NangoError;
 }): Promise<void> {
@@ -219,8 +213,6 @@ async function onFailure({
             createdAt: Date.now()
         });
     }
-    const logCtx = await logContextGetter.get({ id: activityLogId });
-    await logCtx.error(error.message, { error });
 
     if (syncJobId) {
         await updateSyncJobStatus(syncJobId, SyncStatus.STOPPED);

packages/server/lib/controllers/proxy.controller.ts

@@ -1,5 +1,5 @@
 import type { Request, Response, NextFunction } from 'express';
-import type { OutgoingHttpHeaders, IncomingHttpHeaders } from 'http';
+import type { OutgoingHttpHeaders } from 'http';
 import type { TransformCallback } from 'stream';
 import type stream from 'stream';
 import { Readable, Transform, PassThrough } from 'stream';
@@ -10,7 +10,7 @@ import type { AxiosError, AxiosRequestConfig, AxiosResponse } from 'axios';
 import { backOff } from 'exponential-backoff';
 import type { HTTP_VERB, UserProvidedProxyConfiguration, InternalProxyConfiguration, ApplicationConstructedProxyConfiguration } from '@nangohq/shared';
 import { NangoError, LogActionEnum, errorManager, ErrorSourceEnum, proxyService, connectionService, configService, featureFlags } from '@nangohq/shared';
-import { metrics, getLogger, axiosInstance as axios } from '@nangohq/utils';
+import { metrics, getLogger, axiosInstance as axios, getHeaders } from '@nangohq/utils';
 import { logContextGetter } from '@nangohq/logs';
 import { connectionRefreshFailed as connectionRefreshFailedHook, connectionRefreshSuccess as connectionRefreshSuccessHook } from '../hooks/hooks.js';
 import type { LogContext } from '@nangohq/logs';
@@ -162,17 +162,6 @@ class ProxyController {
             metrics.increment(metrics.Types.PROXY_FAILURE);
             next(err);
         } finally {
-            const getHeaders = (hs: IncomingHttpHeaders | OutgoingHttpHeaders): Record<string, string> => {
-                const headers: Record<string, string> = {};
-                for (const [key, value] of Object.entries(hs)) {
-                    if (typeof value === 'string') {
-                        headers[key] = value;
-                    } else if (Array.isArray(value)) {
-                        headers[key] = value.join(', ');
-                    }
-                }
-                return headers;
-            };
             const reqHeaders = getHeaders(req.headers);
             reqHeaders['authorization'] = 'REDACTED';
             await logCtx?.enrichOperation({

packages/server/lib/controllers/sync.controller.ts

@@ -33,7 +33,7 @@ import {
 import type { LogContext } from '@nangohq/logs';
 import { defaultOperationExpiration, logContextGetter } from '@nangohq/logs';
 import type { LastAction } from '@nangohq/records';
-import { isHosted } from '@nangohq/utils';
+import { getHeaders, isHosted } from '@nangohq/utils';
 import { records as recordsService } from '@nangohq/records';
 import type { RequestLocals } from '../utils/express.js';
 import { getOrchestrator } from '../utils/utils.js';
@@ -324,7 +324,6 @@ class SyncController {
                 return;
             } else {
                 span.setTag('nango.error', actionResponse.error);
-                await logCtx.error('Failed to run action', { error: actionResponse.error });
                 await logCtx.failed();
 
                 errorManager.errResFromNangoErr(res, actionResponse.error);
@@ -340,6 +339,20 @@ class SyncController {
             }
 
             next(err);
+        } finally {
+            const reqHeaders = getHeaders(req.headers);
+            reqHeaders['authorization'] = 'REDACTED';
+            await logCtx?.enrichOperation({
+                request: {
+                    url: `${req.protocol}://${req.get('host')}${req.originalUrl}`,
+                    method: req.method,
+                    headers: reqHeaders
+                },
+                response: {
+                    code: res.statusCode,
+                    headers: getHeaders(res.getHeaders())
+                }
+            });
         }
     }