fix: action and webhook logs improvements #2634
Conversation
| @@ -105,11 +105,6 @@ export async function startAction(task: TaskAction): Promise<Result<void>> { | |||
| } | |||
| } | |||
| export async function handleActionSuccess({ nangoProps }: { nangoProps: NangoProps }): Promise<void> { | |||
| const logCtx = await logContextGetter.get({ id: String(nangoProps.activityLogId) }); | |||
There was a problem hiding this comment.
This will be a relieve for the infra I think 👌🏻
| connection: connection.connection_id, | ||
| integration: connection.provider_config_key |
There was a problem hiding this comment.
those 2 things are already logged in the operation (applicable for multiple lines)
There was a problem hiding this comment.
can we easily show them in the message payload then?
There was a problem hiding this comment.
they are shown on top of the Operation drawer
There was a problem hiding this comment.
yes but this is to also show this info in the individual message payload.
There was a problem hiding this comment.
ideally we don't store those information again just for display reason, you can pass the operation to the message drawer if needed
There was a problem hiding this comment.
got it. Let me remove them. This info is not absolutely required in the message drawing for now
| @@ -340,6 +339,20 @@ class SyncController { | |||
| } | |||
|
|
|||
| next(err); | |||
| } finally { | |||
| const reqHeaders = getHeaders(req.headers); | |||
There was a problem hiding this comment.
On your other PR you also need this + the redacted
Maybe you should consolidate everything with this new function
There was a problem hiding this comment.
yes that's my goal
I will work on sync logs improvements when I am done with actions |
- Added request/response to action operation payload - Removed duplicates logs. We were indeed logging more or less the same thing at different levels (handler in jobs, trigger function and/or controller). - Log messages for actions and webhooks are now shorter and mostly without data (ex: 'Started action A', 'The action failed') Details like connection, provider, truncated response, error payload are now in the log payload I want to add request/response details for proxied requests made within a script but it requires modifying the persist API which is ingesting the logs coming from the runner. I will do that in next PR
TBonnin
force-pushed
the
tbonnin/action-logs-improvements
branch
from
d4bb39c
to
61438a2
Compare
Details like connection, provider, truncated response, error payload are now in the log payload
I want to add request/response details for proxied requests made within a script but it requires modifying the persist API which is ingesting the logs coming from the runner. I will do that in next PR. It would also be useful for the validation warning message
Note: You can ignore the
[Object Object], 100log in the screenshot below. It is me manually logging something in the test scriptAction operation:
Action started log
Action successful log
Failed action operation:
Action failed log
Same for webhook.
Note that operation is not enriched with request/response. @samuel I'll ping you to see if we can add it
Issue ticket number and link
https://linear.app/nango/issue/NAN-1525/improve-actions-error-logs