-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Duplicate syncs & schedules in DB #791
Comments
If a pre existing connection id is created again and goes through the oauth flow the sync will be initiated again
No major impact except that sync data is overwritten and their connection sync tab will have duplicates.
Prevent further duplicates with #796. We should write a script that removes dupes and deletes the sync and duplicate schedules and then add the migration that enforced uniqueness at the db level |
Thank you for getting to the bottom of this @khaliqgant. The script will also help with having precise BI! |
* [gh-#322] start api key auth and validation for the providers.yaml * [gh-#322] add validation logic * [gh-#322] later version and relative path * [gh-#322] full path * [gh-#322] better regex * [gh-#322] add more props and set additionalProperties to true * [gh-#322] valid json * [gh-#322] oauth -> auth and start auth service work * [gh-#322] formatting * [gh-#322] api auth updates with type wrangling * [gh-#322] add type for api and render fields in connection details • Kick off sync if connection was upserted * [gh-#322] add shortcut and update errors * [gh-#322] consolidate methods * [gh-#322] update get connection * [gh-#322] proxy headers and query params + tests * [gh-#322] Authorization param override * [gh-#322] hmac support * [gh-#322] base_api_url -> proxy.base_url * [gh-#322] getToken sdk for api token * [gh-#322] indentation * [gh-#322] don't delete type * [gh-#322] clean up proxy calls * [gh-#322] info circle for notice on api auth * [gh-#322] add logic for auth link and fix zustand * [gh-#322] add credentials * [gh-#322] semantic html * [gh-#322] TODO remove after bumping verion * [gh-#322] support extra headers * [gh-#322] restore whitespace * [gh-#322] base_api_url -> proxy.base_url * [gh-#322] import connection for api and oauth * [gh-#322] Resolves #804 * [gh-#322] better check for base_url, report error, and restart on providers.yaml change * [gh-#322] make key prop dynamic for config.template.proxy.query * [gh-#322] quote connection creds * [gh-#322] single quote for consistency * [gh-#322] consolidate * [gh-#322] type declarations * [gh-#322] cleanup * [gh-#322] better comment * [gh-#322] handle invalid auth mode * [gh-#322] reorder * [gh-#792] add migrations Resolves #780 * [gh-#322] Docs for API Key * [gh-#322] Remove type from import connection endpoint * [gh-#792] soft deletes * [gh-#322] check for credentials length * [gh-#792] [gh-#322] check for credentials length * [gh-#322] fix trailing * [gh-#322] Remove path from base URL * [gh-#792] use same keys as expected for the cli * [gh-#792] change upsert method * [gh-#792] fix merge markers * [gh-#792] remove debug * [gh-#792] remove cast * [gh-#792] analytics and job tracking * [gh-#792] deleted on joins * [gh-#792] add last_fetch_at * [gh-#791] deleted fixes * [gh-#791] update lookup, resolves #753 * [gh-#792] fix delete logic * [gh-#791] set active to false as well * [gh-#792] filter on deleted false * [gh-#792] and more deleted clauses * [gh-#792] updateLastFetched in more instances --------- Co-authored-by: Bastien Beurier <[email protected]>
As discussed this morning with Khaliq, we noticed that the
_nango_syncs
table has duplicatenango_connection_id
/name
pairs, each having a corresponding_nang_sync_schedules
row (that hasRUNNING
status).We should investigate:
Also with this issue dev creds should be encrypted
The text was updated successfully, but these errors were encountered: