[gh-#791] await initiate and return null if sync exists (#796)

NangoHQ · Jul 18, 2023 · e5b5e12 · e5b5e12
1 parent a95d434
commit e5b5e12
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/packages/server/lib/controllers/oauth.controller.ts b/packages/server/lib/controllers/oauth.controller.ts
@@ -707,7 +707,7 @@ class OAuthController {
 
             if (updatedConnection) {
                 const syncClient = await SyncClient.getInstance();
-                syncClient?.initiate(updatedConnection.id);
+                await syncClient?.initiate(updatedConnection.id);
             }
 
             await updateSuccessActivityLog(activityLogId, true);

diff --git a/packages/shared/lib/services/sync/sync.service.ts b/packages/shared/lib/services/sync/sync.service.ts
@@ -43,7 +43,7 @@ export const createSync = async (nangoConnectionId: number, name: string): Promi
     const existingSync = await getSyncByIdAndName(nangoConnectionId, name);
 
     if (existingSync) {
-        throw new Error(`Sync with name ${name} already exists. Please reach out to support to report this issue.`);
+        return null;
     }
 
     const sync: Sync = {