Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Orc writer wrong for timestamps prior to 1970 #140

Open
revans2 opened this issue Jun 10, 2020 · 3 comments
Open

[BUG] Orc writer wrong for timestamps prior to 1970 #140

revans2 opened this issue Jun 10, 2020 · 3 comments
Labels
bug Something isn't working P1 Nice to have for release SQL part of the SQL/Dataframe plugin

Comments

@revans2
Copy link
Collaborator

revans2 commented Jun 10, 2020

Describe the bug
When writing timestamps prior to 1970 and reading them back in using the CPU the results are wrong.

Steps/Code to reproduce bug
An integration test has been added for this.
@revans2 revans2 added bug Something isn't working ? - Needs Triage Need team to review and classify SQL part of the SQL/Dataframe plugin labels Jun 10, 2020
@jlowe
Copy link
Member

jlowe commented Jun 10, 2020

This seems likely to be a bug in libcudf's ORC reader. Has that been confirmed and if so, is there a corresponding bug against libcudf?

@revans2
Copy link
Collaborator Author

revans2 commented Jun 10, 2020

I have only filed issues against our project so far. I have not had time to dig into any of them and confirm if there are cudf issues or not. @jlowe if that is something you want to do feel free to dig into it.

@sameerz sameerz added P1 Nice to have for release and removed ? - Needs Triage Need team to review and classify labels Aug 18, 2020
@pxLi pxLi mentioned this issue Dec 8, 2020
Closed
@ttnghia
Copy link
Collaborator

ttnghia commented Sep 13, 2022 •
edited
Loading

Is this still relevant? It seems we just had a fixed in rapidsai/cudf#11525 but there is still rapidsai/cudf#11691.

Edit: Found that the merged PR didn't fix this. It fixed orc reader but didn't fix orc writer.

@ttnghia ttnghia mentioned this issue Sep 16, 2022
Merged
tgravescs pushed a commit to tgravescs/spark-rapids that referenced this issue Nov 30, 2023
@nvauto
Update submodule cudf to 17c913c (NVIDIA#140)
bd2c699 
Signed-off-by: spark-rapids automation <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working P1 Nice to have for release SQL part of the SQL/Dataframe plugin
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jlowe @revans2 @sameerz @ttnghia