Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix orc test #1312

Closed
wants to merge 1 commit into from
Closed

fix orc test #1312

wants to merge 1 commit into from

Conversation

pxLi
Copy link
Collaborator

@pxLi pxLi commented Dec 8, 2020

Signed-off-by: Peixin Li [email protected]

I cannot reproduce on ubuntu env. But I can easily reproduce this on integration tests w/ our integration centos image:

  1. test_read_round_trip-fail
  2. test_simple_partitioned_read-fail

If I increase the time start a bit larger than the epoch (1970.1.1, not the same as since that would bring the weighted special cases) , then the test works well. Not sure what's the root cause here.

This PR does not need to be merged if anyone else has better context about this, related to #140

Signed-off-by: Peixin Li <[email protected]>
@pxLi pxLi added the test Only impacts tests label Dec 8, 2020
@pxLi
Copy link
Collaborator Author

pxLi commented Dec 8, 2020

build

@pxLi pxLi linked an issue Dec 8, 2020 that may be closed by this pull request
@pxLi pxLi added the bug Something isn't working label Dec 8, 2020
@jlowe
Copy link
Member

jlowe commented Dec 8, 2020

@nvdbaranec has been trying to reproduce this in an interactive environment without success. @pxLi if you can reproduce this easily, it would be great if you could work with Dave to help setup a repro case for him to debug. I don't want to sweep this bug under the rug, which is what this change wants to do.

@pxLi
Copy link
Collaborator Author

pxLi commented Dec 9, 2020

@nvdbaranec has been trying to reproduce this in an interactive environment without success. @pxLi if you can reproduce this easily, it would be great if you could work with Dave to help setup a repro case for him to debug. I don't want to sweep this bug under the rug, which is what this change wants to do.

Yeah, I provided him the env locally to reproduce yesterday. this PR is just a workaround which was intended to be taken as a real bug fix.

@jlowe
Copy link
Member

jlowe commented Dec 9, 2020

Based on @nvdbaranec's investigations, this appears to be an issue with the GMT timezone in the CentOS environment. As such I think the approach in #1337 is more appropriate since we don't need to unnecessarily restrict the range of timestamps being tested.

@pxLi
Copy link
Collaborator Author

pxLi commented Dec 9, 2020

sure, let me close this one

@pxLi pxLi closed this Dec 9, 2020
tgravescs pushed a commit to tgravescs/spark-rapids that referenced this pull request Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working test Only impacts tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] orc_test.py is failing
2 participants