Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle QualX behaviour when Qual Tool does not generate any outputs #1095

Merged
merged 1 commit into from
Jun 10, 2024
Merged

Handle QualX behaviour when Qual Tool does not generate any outputs #1095

merged 1 commit into from
Jun 10, 2024

Conversation

parthosa
Copy link
Collaborator

@parthosa parthosa commented Jun 7, 2024

Fixes #1094.

In QualX, if there are no outputs from Qualification Tool, we raise an exception. The same exception will be thrown when there is no data after preprocessing. This is not ideal and we should differentiate the two cases.

This PR changes the behaviour:

  • If there are no outputs from Qual tool, showing a warning and return an empty dataset.
  • If there is no data after preprocessing, we would raise a ValueError in that scenario.

Output:

Case: Qual Tool does not generate any output

WARNING spark_rapids_tools.tools.qualx.qualx_main: Qualification tool metrics are missing. Speedup predictions will be skipped.

@parthosa parthosa added the user_tools Scope the wrapper module running CSP, QualX, and reports (python) label Jun 7, 2024
@parthosa parthosa self-assigned this Jun 7, 2024
@amahussein amahussein merged commit e68e8d0 into NVIDIA:dev Jun 10, 2024
16 checks passed
@parthosa parthosa deleted the spark-rapids-tools-1094 branch October 9, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amahussein amahussein amahussein approved these changes

@leewyang leewyang Awaiting requested review from leewyang

@eordentlich eordentlich Awaiting requested review from eordentlich

@cindyyuanjiang cindyyuanjiang Awaiting requested review from cindyyuanjiang

Assignees

@parthosa parthosa

Labels
user_tools Scope the wrapper module running CSP, QualX, and reports (python)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Handle QualX behaviour when Qual Tool does not generate any outputs.
2 participants
@parthosa @amahussein