Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Handle QualX behaviour when Qual Tool does not generate any outputs. #1094

Closed
parthosa opened this issue Jun 7, 2024 · 0 comments · Fixed by #1095
Closed

[BUG] Handle QualX behaviour when Qual Tool does not generate any outputs. #1094

parthosa opened this issue Jun 7, 2024 · 0 comments · Fixed by #1095
Assignees
@parthosa
Labels
bug Something isn't working user_tools Scope the wrapper module running CSP, QualX, and reports (python)

Comments

@parthosa
Copy link
Collaborator

parthosa commented Jun 7, 2024 •
edited
Loading

In QualX, if there are no outputs from Qualification Tool, we raise an exception. The same exception will be thrown when there is no data after preprocessing. This is not ideal and we should differentiate the two cases.

Instead, we should show a warning like:

WARNING spark_rapids_tools.tools.qualx.qualx_main: Qualification tool metrics are missing. Speedup predictions will be skipped.
@parthosa parthosa added bug Something isn't working user_tools Scope the wrapper module running CSP, QualX, and reports (python) ? - Needs Triage labels Jun 7, 2024
@parthosa parthosa self-assigned this Jun 7, 2024
@parthosa parthosa mentioned this issue Jun 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@parthosa parthosa

Labels
bug Something isn't working user_tools Scope the wrapper module running CSP, QualX, and reports (python)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handle QualX behaviour when Qual Tool does not generate any outputs parthosa/spark-rapids-tools
1 participant
@parthosa