Sync tools with plugin newly supported operators #1066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: cindyyuanjiang <[email protected]>
cindyyuanjiang
added
feature request
amahussein
reviewed
Jun 5, 2024
There was a problem hiding this comment.
Thanks @cindyyuanjiang !
Can you add some details to the PR description to explain why there is no need to change in the scala code (unit tests/SQLPlanParser).
This makes it easy for anyone to get the context of the changes and to know where to start if we need to followup on the opertator's support.
|
Thanks @amahussein! I added more details in PR description. |
nartal1
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1045
Changes
Plugin added a new expression
BoundReference. This PR adds its support in tools.Notes
BoundReferenceis not a sql function. After several iterations, I couldn't reproduce this expression in an eventlog.