Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Make top candidates view as the default view in user tools #868

Closed
parthosa opened this issue Mar 22, 2024 · 0 comments · Fixed by #879
Closed

[FEA] Make top candidates view as the default view in user tools #868

parthosa opened this issue Mar 22, 2024 · 0 comments · Fixed by #879
Assignees
@amahussein
Labels
feature request New feature or request user_tools Scope the wrapper module running CSP, QualX, and reports (python)

Comments

@parthosa
Copy link
Collaborator

As a follow up of top candidates feature, we cannot make it as default view until #867 (grouping applications by name in user tools) is fixed.
@parthosa parthosa added feature request New feature or request ? - Needs Triage labels Mar 22, 2024
@parthosa parthosa mentioned this issue Mar 22, 2024
Closed
@parthosa parthosa added the user_tools Scope the wrapper module running CSP, QualX, and reports (python) label Mar 25, 2024
@amahussein amahussein self-assigned this Mar 26, 2024
amahussein added a commit to amahussein/spark-rapids-tools that referenced this issue Mar 26, 2024
@amahussein
Make top candidates view as the default view in user-tools
05d392c 
Signed-off-by: Ahmed Hussein (amahussein) <[email protected]>

Fixes NVIDIA#868

- Use Top-candidate view as default for user-tools qualification
- Revisit the spark_rapids CLI to verify that resetting the filter based
  on user-input does not override the default flag argument
- Fix unit-tests
@amahussein amahussein mentioned this issue Mar 26, 2024
Merged
amahussein added a commit that referenced this issue Mar 27, 2024
@amahussein
[FEA] Make top candidates view as the default view in user-tools (#879)
76eace4 
* Make top candidates view as the default view in user-tools

Signed-off-by: Ahmed Hussein (amahussein) <[email protected]>

Fixes #868

- Use Top-candidate view as default for user-tools qualification
- Revisit the spark_rapids CLI to verify that resetting the filter based
  on user-input does not override the default flag argument
- Fix unit-tests

---------

Signed-off-by: Ahmed Hussein (amahussein) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amahussein amahussein

Labels
feature request New feature or request user_tools Scope the wrapper module running CSP, QualX, and reports (python)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[FEA] Make top candidates view as the default view in user-tools amahussein/spark-rapids-tools
2 participants
@parthosa @amahussein