Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Fix standard output and qualification summary csv with TCO feature #867

Closed
parthosa opened this issue Mar 22, 2024 · 0 comments · Fixed by #875
Closed

[BUG] Fix standard output and qualification summary csv with TCO feature #867

parthosa opened this issue Mar 22, 2024 · 0 comments · Fixed by #875
Assignees
@parthosa
Labels
bug Something isn't working user_tools Scope the wrapper module running CSP, QualX, and reports (python)

Comments

@parthosa
Copy link
Collaborator

parthosa commented Mar 22, 2024 •
edited by amahussein
Loading

Currently, if multiple event logs have same name, user tools groups them all and averages the metric. This can be misleading for certain cases especially for Databricks when all apps have same name - Databricks Shell.

With features Top-candidates-Filter and Estimation-model, this problem gets highlighted further.

Potential solutions could be:

  1. Generate two csv - grouped, individual apps.
  2. Putting this under a flag
  3. Identify other columns or composite keys instead of app name
@parthosa parthosa added bug Something isn't working ? - Needs Triage labels Mar 22, 2024
This was referenced Mar 22, 2024
Closed
Closed
@amahussein amahussein changed the title [BUG] Fix standard output and qualification summary csv when multiple event logs have same app name. [BUG] Fix standard output and qualification summary csv when multiple event logs have same app name Mar 25, 2024
@amahussein amahussein added the user_tools Scope the wrapper module running CSP, QualX, and reports (python) label Mar 25, 2024
@amahussein amahussein changed the title [BUG] Fix standard output and qualification summary csv when multiple event logs have same app name [BUG] Fix standard output and qualification summary csv with TCO feature Mar 25, 2024
@parthosa parthosa mentioned this issue Mar 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@parthosa parthosa

Labels
bug Something isn't working user_tools Scope the wrapper module running CSP, QualX, and reports (python)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Introduce new csv file containing output for all apps before grouping parthosa/spark-rapids-tools
2 participants
@parthosa @amahussein