Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT PR] added AIG for SD and documentation #286

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rohitrango
Copy link
Contributor

What does this PR do ?

Adds documentation and script for anneal_sd.py - AIG for SDv1.x models. This is a draft PR that indicates the changes to be made. Ideally after #270 is merged, the anneal_sd.py code can be merged into the other file since there is a lot of duplicate code, but merging them is not trivial.

Changelog

  • Please update the CHANGELOG.md under next version with high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Before your PR is "Ready for review"

Pre checks:

Checklist when contributing a new algorithm

  • Does the trainer resume and restore model state all states?
  • Does the trainer support all parallelism techniques(PP, TP, DP)?
  • Does the trainer support max_steps=-1 and validation?
  • Does the trainer only call APIs defined in alignable_interface.py?
  • Does the trainer have proper logging?

Additional Information

  • Related to # (issue)

@rohitrango rohitrango marked this pull request as draft September 6, 2024 18:41
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant