Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added "Annealed importance guidance" and DRaFT+ docs #270

Merged
merged 10 commits into from
Sep 6, 2024
Merged

Added "Annealed importance guidance" and DRaFT+ docs #270

merged 10 commits into from
Sep 6, 2024

Conversation

rohitrango
Copy link
Contributor

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Changelog

  • Please update the CHANGELOG.md under next version with high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this

Before your PR is "Ready for review"

Pre checks:

Checklist when contributing a new algorithm

  • Does the trainer resume and restore model state all states?
  • Does the trainer support all parallelism techniques(PP, TP, DP)?
  • Does the trainer support max_steps=-1 and validation?
  • Does the trainer only call APIs defined in alignable_interface.py?
  • Does the trainer have proper logging?

Additional Information

  • Related to # (issue)

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Aug 26, 2024
@rohitrango
Copy link
Contributor Author

@JRD971000 @terrykong

@JRD971000 JRD971000 self-requested a review August 30, 2024 18:49
@rohitrango
Copy link
Contributor Author

  • remove scripts
  • remove local paths

JRD971000
JRD971000 previously approved these changes Sep 5, 2024
View reviewed changes
terrykong
terrykong requested changes Sep 6, 2024
View reviewed changes
examples/mm/stable_diffusion/anneal_sd.py Outdated Show resolved Hide resolved
examples/mm/stable_diffusion/anneal_sd.py Outdated Show resolved Hide resolved
examples/mm/stable_diffusion/anneal_sdxl.py Show resolved Hide resolved
examples/mm/stable_diffusion/anneal_sd.py Outdated Show resolved Hide resolved
examples/mm/stable_diffusion/anneal_sdxl.py Show resolved Hide resolved
examples/mm/stable_diffusion/anneal_sdxl.py Outdated Show resolved Hide resolved
examples/mm/stable_diffusion/anneal_sd.py Outdated Show resolved Hide resolved
examples/mm/stable_diffusion/anneal_sdxl.py Outdated Show resolved Hide resolved
@rohitrango
removing AIG for SD for now and related documentation - Ali will take
de8862b 
care of the merging of the two scripts

Also changed the weighting function, timer defaults, and relative paths
for saving images

Signed-off-by: Rohit Jena <[email protected]>
@rohitrango
Merge branch 'draftp_anneal_docs' of github.com:rohitrango/NeMo-Align…
6470842 
…er into draftp_anneal_docs
@rohitrango rohitrango mentioned this pull request Sep 6, 2024
Draft
8 tasks
@terrykong terrykong merged commit da3f5f8 into NVIDIA:main Sep 6, 2024
3 checks passed
abukharin3 pushed a commit to abukharin3/NeMo-Aligner that referenced this pull request Sep 25, 2024
@rohitrango @pre-commit-ci
Added "Annealed importance guidance" and DRaFT+ docs (NVIDIA#270)
2462a8a 
Signed-off-by: Rohit Jena <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: Alexander Bukharin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terrykong terrykong terrykong approved these changes

@JRD971000 JRD971000 JRD971000 left review comments

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rohitrango @terrykong @JRD971000