Panel front end #638
Panel front end #638
Conversation
| .cell.small-12 | ||
| = f.submit 'Update Panel Information', class: 'button' | ||
|
|
||
| :javascript |
There was a problem hiding this comment.
Should this be separated out to its own js file and then included here?
There was a problem hiding this comment.
agreed, but i'm going to leave this for now. there are other files (e.g. grant form) where this needs to happen.
| %h2 | ||
| Review Panel | ||
| %strong | ||
| CHANGE THIS LOGIC |
There was a problem hiding this comment.
Is this supposed to be changed?
There was a problem hiding this comment.
this is coming up in the next PR...
| end | ||
|
|
||
| it 'does not require end_datetime and start_dateime to be set' do | ||
| panel.start_datetime = nil | ||
| panel.end_datetime = nil | ||
| expect(panel).to be_valid | ||
| end | ||
| end | ||
|
|
||
| context 'meeting_link' do |
There was a problem hiding this comment.
These should potentially be separated. You can also use shared_examples to call these.
| end | ||
| end | ||
|
|
||
| context 'before start_datetime' do |
There was a problem hiding this comment.
Maybe use shared_examples here also.
| visit edit_grant_panel_path(grant) | ||
| end | ||
|
|
||
| scenario 'can visit the edit page' do |
There was a problem hiding this comment.
These could also be handled by shared examples.
| visit edit_grant_panel_path(grant) | ||
| end | ||
|
|
||
| scenario 'may update' do |
| let(:grant) { create(:published_open_grant_with_users, :with_reviewer) } | ||
| let(:new_user) { create(:user) } | ||
|
|
||
| context 'roles' do |
There was a problem hiding this comment.
This is a good place for shared examples.
There was a problem hiding this comment.
since these are testing different, dynamically-created methods, i'm going to leave them as is
|
@mattbaumann1 approval via conversation in Teams |
Closes #629
Closes #628