Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a panel model #627

Closed
lmkw opened this issue Sep 22, 2020 · 0 comments · Fixed by #633
Closed

Create a panel model #627

lmkw opened this issue Sep 22, 2020 · 0 comments · Fixed by #633
Assignees
@mattbaumann1 @jseraf
Labels
2 days Time: 2 days Community Feedback feature New feature panel

Comments

@lmkw
Copy link
Contributor

lmkw commented Sep 22, 2020 •
edited
Loading

Needs grant attribute to fetch reviewers (required)
Remove panel date and panel location from grant
Add panel start and end date to panel model (required and has logic to be after review close date)
Add panel location
Add panel link
Add help text (for Admin to give to reviewers)
@lmkw lmkw added the 2 days Time: 2 days label Sep 22, 2020
@lmkw lmkw mentioned this issue Sep 22, 2020
Closed
jseraf added a commit that referenced this issue Sep 23, 2020
@jseraf
Scaffold Panel model #627
cc4afdc
jseraf added a commit that referenced this issue Sep 23, 2020
@jseraf
Migrate Grant panel attributes to Panel #627
580c423
jseraf added a commit that referenced this issue Sep 23, 2020
@jseraf
Move panel date validations to panel model #627
9bc4a25
jseraf added a commit that referenced this issue Sep 23, 2020
@jseraf
Remove panel attributes from grant factory and related specs #627
b33e6a1
@jseraf jseraf mentioned this issue Sep 23, 2020
Merged
@jseraf jseraf linked a pull request Sep 23, 2020 that will close this issue
Add panel model #633
Merged
jseraf added a commit that referenced this issue Sep 24, 2020
@jseraf
Fix date validation and failing spec #627
a25bf11
jseraf added a commit that referenced this issue Sep 24, 2020
@jseraf
PR feedback #627
1c88eb6
jseraf added a commit that referenced this issue Sep 24, 2020
@jseraf
Add panel model (#633)
fe43b52 
* Scaffold Panel model #627

* Migrate Grant panel attributes to Panel #627

* Move panel date validations to panel model #627
@jseraf jseraf closed this as completed Sep 24, 2020
jseraf added a commit that referenced this issue Oct 6, 2020
@jseraf
Raname panel yaml file #627
7905dea
jseraf added a commit that referenced this issue Oct 6, 2020
@jseraf
Add panel paper trail #627
3d059b3
jseraf added a commit that referenced this issue Oct 6, 2020
@jseraf
Add panel to new and duplicated grant #627
8516fe9
jseraf added a commit that referenced this issue Oct 6, 2020
@jseraf
Initial model validations and specs #627
1b89516
jseraf added a commit that referenced this issue Oct 6, 2020
@jseraf
Add role-specific getter methods to Grant #627
1abedae
jseraf added a commit that referenced this issue Oct 6, 2020
@jseraf
Add Panel routes, policy, controller #627
20c3ee5
jseraf added a commit that referenced this issue Oct 6, 2020
@jseraf
Add Panel link to Grant header #627
b0dc47e
jseraf added a commit that referenced this issue Oct 6, 2020
@jseraf
Initial Panel edit view, specs #627
54603c6
jseraf added a commit that referenced this issue Oct 6, 2020
@jseraf
Rename panel_mode? method to is_open? for clarity #627
abf7a94
jseraf added a commit that referenced this issue Oct 6, 2020
@jseraf
Clarify panel start/end date error #627
589691e
jseraf added a commit that referenced this issue Oct 6, 2020
@jseraf
WIP: draft panel views, update grant factories and specs #627
d46f736
jseraf added a commit that referenced this issue Oct 7, 2020
@jseraf
PR feedback: add paper trail earlier to avoid migration error #627
4a3a27f
jseraf added a commit that referenced this issue Oct 7, 2020
@jseraf
PR feedback: panel instructions input and specs #627
c656db8
jseraf added a commit that referenced this issue Oct 7, 2020
@jseraf
PR feedback: Move cross-policy grant access methods to a separate mod…
bbf566b 
…ule #627
jseraf added a commit that referenced this issue Oct 8, 2020
@jseraf
PR feedback: use shared examples in specs #627
6e97a80
jseraf added a commit that referenced this issue Oct 8, 2020
@jseraf
Panel front end (#638)
9a39c57 
* Raname panel yaml file #627

* Add panel paper trail #627

* Add panel to new and duplicated grant #627

* Initial model validations and specs #627

* Add role-specific getter methods to Grant #627

* Add Panel routes, policy, controller #627

* Add Panel link in Grant header #627

* Initial Panel edit view, specs #627

* Rename panel_mode? method to is_open? for clarity #627

* Clarify panel start/end date error #627

* Draft panel views, update grant factories and specs #627
jseraf added a commit that referenced this issue Oct 20, 2020
@jseraf
Fix post-merge specs following #627
f7e7294
jseraf added a commit that referenced this issue Oct 22, 2020
@jseraf
Add submissions and reviews to panel (#651)
abb5b67 
* Fix post-merge specs following #627

* Change name of unused :eager_loading scope to :with_responses, expand scope #628

* Add submission show route to panel #628

* Change review_period_closed? to check against .end_of_day - found during #628

* Align table cells to top of row #628

* Change link path based on in-/complete review. Found during #628

* Include foundation breadcrumb css #628

* Add panel open/closed callout and panel date display helper #628

* Account for unscheduled panels. #628

* Specs for will_[open/close]_at_string helper #682

* Remove refactored/deleted partial #628

* Add guard in case dates are empty #628

* Include default sort spec - found during #628

* Redirect panel/submissions to panel :show #628

* Update panel show page #628

* Add views for panel submission and reviews  #628

* CSS updates related to #628

* Factory updates to account for panels #628

* Expand panel specs, add initial panel submissions and review specs #628

* Move panel sub page authorizations to concern #637

* Add/user panel :view_content? policy #637
@mattbaumann1 mattbaumann1 mentioned this issue Jun 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattbaumann1 mattbaumann1

@jseraf jseraf

Labels
2 days Time: 2 days Community Feedback feature New feature panel
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add panel model NUARIG/competitions
3 participants
@mattbaumann1 @jseraf @lmkw