Move sigan agnostic default calibration file to scos-sensor and enable calibrations with default cal file. #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ibration parameters.
…dd test for default sensor calibration data.
…n. Add warnings during sigan and sensor cal loading. Add warning if using default calibration for sensor or sigan cal. Add sigan_calibration and sensor_calibration to base SignalAnalyzerInterface.
aromanielloNTIA
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the default calibration file to the scos-sensor repo. The accompanying scos-sensor pr will include a default cal file (configs/default_calibration.json) that will work for any signal analyzer. The scos-sensor pr will use the default file if configs/sensor_calibration.json or configs/sigan_calibration.json do not exist. This PR introduces checks to see if the default calibration file is being used and will log warnings if it is. This also allows calibrations to be performed with a default calibration file for any signal analyzer. Finally, this fixes a minor bug in power_cycle_and_connect by broadly catching any Exception. Previously, if a power cycle switch was configured but not reachable over the network and the sigan failed to connect the attempt to power cycle would cause an exception that would fail to be caught and this would cause the sigan package to fail to load actions.