Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty calibration parameter support #103

Closed
dboulware opened this issue Dec 8, 2023 · 2 comments · Fixed by #106
Closed

Empty calibration parameter support #103

dboulware opened this issue Dec 8, 2023 · 2 comments · Fixed by #106

Comments

@dboulware
Copy link
Contributor

Calibration should be updated to handle empty calibration parameters. When no calibration parameters are supplied the default calibration data ca be put directly in calibration_data. In addition the example cal files should be deleted and a default cal file should be added to scos-sensor that supports any sigan by using empty calibration parameters.

@aromanielloNTIA
Copy link
Member

I really like the idea of removing the example cal files and replacing them with something that will support any sigan. However, I think there is a need to enforce calibration parameters. Maybe we can require that SignalAnalyzerInterface classes define which calibration parameters are required for a particular sigan. We should avoid a situation where SCOS can apply calibration data when it is not accurate to do so, e.g., if the measurement frequency differs from the calibration frequency, we need to make sure that the calibration data is not used to scale the measurement.

@aromanielloNTIA
Copy link
Member

Closing this as it is done after #106

Still pending some changes in scos-sensor (currently drafted as NTIA/scos-sensor#264)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants