PR for testing OS 3.8.0rc-2 #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will at least add back ext gem setup to work for rc or final version.
Replace OsLib_HelperMethod calls with new runner methods
@mdahlhausen can you take a look at envelope section standards updates. Everything runs and populates tables, but wanted to make sure I used new methods properly.
XcelQAQC test model is failing in E+ need to investigate that. It is only test on that measure
This still uses the resources files with the measure. Hit some issue trying to remove those and only use standards. Should fully update and delete resource files. This will make it easier to maintain and keep it current.
Hoping it will fix the dashboard
Fix issue but hit another one now
have branch in standards that also adds this.
This will allow it to run with 3.8. The older version of the measure with resources files still passes test but the new code standards files on assert for expected values. If can't address than can revert the measure for now.
macumber
reviewed
May 23, 2024
| spec.add_dependency 'bundler', '>= 2.1' | ||
| spec.add_dependency 'openstudio-extension', '~> 0.7.0' | ||
| spec.add_dependency 'openstudio-standards', '~> 0.5.0' | ||
| spec.add_dependency 'bundler', '~> 2.4.10' |
There was a problem hiding this comment.
Can you make bundler less restrictive 'bundler', '~> 2.4'? The same goes for any other dependency, it would be best to be as open as possible.
The same issue exists in https://github.com/NREL/openstudio-extension-gem/blob/v0.8.0/openstudio-extension.gemspec#L32C1-L33C42, that specifies a different version of bundler. If they could both be 'bundler', '~> 2.4' that would be great.
There was a problem hiding this comment.
@kflemin do you think making this less restrictive will create any issues?
CI failing but local run is fine, this change to test model may be necessary.
jmarrec
reviewed
Jun 11, 2024
DavidGoldwasser
commented
Jul 9, 2024
DavidGoldwasser
commented
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Failing Tests
XcelEDAReportingandQAQC: 1 test error 1 skipped (NoMethodError: undefined method `SqlFilemake_qaqc_results_vector' for OpenstudioStandards:Module) (check with Matt if this changed)
** Severe ** For autosizing of AirTerminal:SingleDuct:ParallelPIU:Reheat AIR TERMINAL SINGLE DUCT PARALLEL PIU REHEAT 2, a zone sizing run must be done.(fixed by updating file to do sizing)execAndReturnFirstDouble' for nil:NilClassfloor_area_query = "SELECT Value FROM tabulardatawithstrings WHERE ReportName='AnnualBuildingUtilityPerformanceSummary' AND ReportForString='Entire Facility' AND TableName='Building Area' AND RowName='Net Conditioned Building Area' AND ColumnName='Area' AND Units='m2'"`1) Failure:
XcelEDAReportingandQAQC_Test#test_example_model [openstudio-common-measures-gem/lib/measures/XcelEDAReportingandQAQC/tests/XcelEDAReportingandQAQC_Test.rb:221]:
Expected an annual peak within 0.5kW of 59.8 but got -999.9.
Expected |59.8 - -999.9| (1059.7) to be <= 0.5.
Pre release