Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace OsLib_HelperMethod calls with new runner methods #167

Merged
merged 2 commits into from
May 8, 2024

Conversation

joseph-robertson
Copy link
Contributor

@joseph-robertson joseph-robertson commented May 1, 2024

Replacements:

  • OsLib_HelperMethods.createRunVariables -> runner.getArgumentValues
  • OsLib_HelperMethods.check_upstream_measure_for_arg -> runner.getPastStepValuesForName
  • OsLib_HelperMethods.checkDoubleAndIntegerArguments -> arg.setMinValue and arg.setMaxValue (and runner.validateUserArguments)

@joseph-robertson joseph-robertson self-assigned this May 1, 2024
@DavidGoldwasser DavidGoldwasser marked this pull request as ready for review May 8, 2024 23:51
@DavidGoldwasser DavidGoldwasser merged commit d4434b0 into 0.10.0-rc1 May 8, 2024
0 of 2 checks passed
@DavidGoldwasser DavidGoldwasser deleted the replace-os-lib-helper-methods branch May 8, 2024 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants