Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #5116 - Annoying FT warnings for always XX Scheduled missing the schedule type limits object #5117

Merged
merged 2 commits into from
Mar 25, 2024
Merged

Fix #5116 - Annoying FT warnings for always XX Scheduled missing the schedule type limits object #5117

merged 2 commits into from
Mar 25, 2024

Commits on Mar 19, 2024

  1. Add a failing test demonstrating #5116 

    ```
$ Products/openstudio_energyplus_tests -- --gtest_filter=*NoUselessWarnings*
Running main() from /home/conan/w/BuildSingleReference/.conan/data/gtest/1.11.0/_/_/build/e019a06362b932ca5d1b082b6c112aa150c88de4/source_subfolder/googletest/src/gtest_main.cc
Note: Google Test filter = *NoUselessWarnings*
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from EnergyPlusFixture
[ RUN      ] EnergyPlusFixture.NoUselessWarnings
/home/julien/Software/Others/OpenStudio/src/energyplus/Test/ForwardTranslator_GTest.cpp:987: Failure
Expected equality of these values:
  0
  logMessages.size()
    Which is: 3
Expected no messages logged, got: ["Object of type 'Schedule:Constant' and named 'Always On Discrete', points to an object named OnOff from field 1, but that object cannot be located.", "Object of type 'Schedule:Constant' and named 'Always Off Discrete', points to an object named OnOff 1 from field 1, but that object cannot be located.", "Object of type 'Schedule:Constant' and named 'Always On Continuous', points to an object named Fractional from field 1, but that object cannot be located."]
[  FAILED  ] EnergyPlusFixture.NoUselessWarnings (16 ms)
[----------] 1 test from EnergyPlusFixture (16 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test suite ran. (16 ms total)
[  PASSED  ] 0 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] EnergyPlusFixture.NoUselessWarnings
```
    @jmarrec
    jmarrec committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    c2960b7 View commit details
    Browse the repository at this point in the history

  2. Fix #5116 - reorder the translatation of alwaysOn schedules

    @jmarrec
    jmarrec committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    dc326bb View commit details
    Browse the repository at this point in the history