Fix #5116 - Annoying FT warnings for always XX Scheduled missing the schedule type limits object #5117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
```
$ Products/openstudio_energyplus_tests -- --gtest_filter=*NoUselessWarnings*
Running main() from /home/conan/w/BuildSingleReference/.conan/data/gtest/1.11.0/_/_/build/e019a06362b932ca5d1b082b6c112aa150c88de4/source_subfolder/googletest/src/gtest_main.cc
Note: Google Test filter = *NoUselessWarnings*
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from EnergyPlusFixture
[ RUN ] EnergyPlusFixture.NoUselessWarnings
/home/julien/Software/Others/OpenStudio/src/energyplus/Test/ForwardTranslator_GTest.cpp:987: Failure
Expected equality of these values:
0
logMessages.size()
Which is: 3
Expected no messages logged, got: ["Object of type 'Schedule:Constant' and named 'Always On Discrete', points to an object named OnOff from field 1, but that object cannot be located.", "Object of type 'Schedule:Constant' and named 'Always Off Discrete', points to an object named OnOff 1 from field 1, but that object cannot be located.", "Object of type 'Schedule:Constant' and named 'Always On Continuous', points to an object named Fractional from field 1, but that object cannot be located."]
[ FAILED ] EnergyPlusFixture.NoUselessWarnings (16 ms)
[----------] 1 test from EnergyPlusFixture (16 ms total)
[----------] Global test environment tear-down
[==========] 1 test from 1 test suite ran. (16 ms total)
[ PASSED ] 0 tests.
[ FAILED ] 1 test, listed below:
[ FAILED ] EnergyPlusFixture.NoUselessWarnings
```
jmarrec
added
severity - Normal Bug
component - IDF Translation
Pull Request - Ready for CI
jmarrec
commented
Mar 19, 2024
Comment on lines
+968
to
+988
| TEST_F(EnergyPlusFixture, NoUselessWarnings) { | ||
| // Test for #5116 | ||
| Model m; | ||
| auto yd = m.getUniqueModelObject<model::YearDescription>(); | ||
| EXPECT_TRUE(yd.setDayofWeekforStartDay("Tuesday")); | ||
|
|
||
| ForwardTranslator ft; | ||
| StringStreamLogSink sink; | ||
| sink.setLogLevel(Warn); | ||
|
|
||
| Workspace w = ft.translateModel(m); | ||
| EXPECT_EQ(0u, ft.errors().size()); | ||
| EXPECT_EQ(0u, ft.warnings().size()); | ||
|
|
||
| std::vector<openstudio::LogMessage> logMessages = sink.logMessages(); | ||
|
|
||
| std::vector<std::string> logStrings; | ||
| std::transform(logMessages.cbegin(), logMessages.cend(), std::back_inserter(logStrings), | ||
| [](const auto& logMessage) { return logMessage.logMessage(); }); | ||
| EXPECT_EQ(0, logMessages.size()) << fmt::format("Expected no messages logged, got: {}", logStrings); | ||
| } |
There was a problem hiding this comment.
New test.
Before fix:
$ Products/openstudio_energyplus_tests -- --gtest_filter=*NoUselessWarnings*
Running main() from /home/conan/w/BuildSingleReference/.conan/data/gtest/1.11.0/_/_/build/e019a06362b932ca5d1b082b6c112aa150c88de4/source_subfolder/googletest/src/gtest_main.cc
Note: Google Test filter = *NoUselessWarnings*
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from EnergyPlusFixture
[ RUN ] EnergyPlusFixture.NoUselessWarnings
/home/julien/Software/Others/OpenStudio/src/energyplus/Test/ForwardTranslator_GTest.cpp:987: Failure
Expected equality of these values:
0
logMessages.size()
Which is: 3
Expected no messages logged, got: ["Object of type 'Schedule:Constant' and named 'Always On Discrete', points to an object named OnOff from field 1, but that object cannot be located.", "Object of type 'Schedule:Constant' and named 'Always Off Discrete', points to an object named OnOff 1 from field 1, but that object cannot be located.", "Object of type 'Schedule:Constant' and named 'Always On Continuous', points to an object named Fractional from field 1, but that object cannot be located."]
[ FAILED ] EnergyPlusFixture.NoUselessWarnings (16 ms)
[----------] 1 test from EnergyPlusFixture (16 ms total)
[----------] Global test environment tear-down
[==========] 1 test from 1 test suite ran. (16 ms total)
[ PASSED ] 0 tests.
[ FAILED ] 1 test, listed below:
[ FAILED ] EnergyPlusFixture.NoUselessWarnings
Comment on lines
+3675
to
+3683
| // Make sure these get in the idf file | ||
| { | ||
| auto schedule = model.alwaysOnDiscreteSchedule(); | ||
| translateAndMapModelObject(schedule); | ||
| schedule = model.alwaysOffDiscreteSchedule(); | ||
| translateAndMapModelObject(schedule); | ||
| schedule = model.alwaysOnContinuousSchedule(); | ||
| translateAndMapModelObject(schedule); | ||
| } |
There was a problem hiding this comment.
Just reordering things a bit.
There was a problem hiding this comment.
Reordering is the fix?
There was a problem hiding this comment.
yep. auto schedule = model.alwaysOnDiscreteSchedule(); => this creates a schedule BUT also a ScheduleTypeLimits, if it wasn't instantiated already.
I put it above and not below the loop to translate all ScheduleTypeLimits.
Translating a scheduleconstant does not trigger translate of the ScheduleTypeLimits attached to it.
|
CI Results for dc326bb:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request overview
Pull Request Author
src/model/test)src/energyplus/Test)src/osversion/VersionTranslator.cpp)Labels:
IDDChangeAPIChangePull Request - Ready for CIso that CI builds your PRReview Checklist
This will not be exhaustively relevant to every PR.