-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DX Cooling coil lower cutoff temperature #3976
Labels
Comments
I'm on it. Do you have a reference of all objects that are missing it or do I need to dig it up? @kbenne |
List of objects missing the field:
Here's a script I used to find the objects that are missing it: require 'openstudio'
field_name = "Minimum Outdoor Dry-Bulb Temperature for Compressor Operation"
puts "Parsing ProposedEnergy+.idd"
puts "=========================================================================="
ep_factory = OpenStudio::IddFileAndFactoryWrapper.new("EnergyPlus".to_IddFileType)
ep_objs = []
ep_factory.objects.each do |obj|
obj.numFields.times do |i|
if obj.getField(i).get.name == field_name
puts "#{obj.name} - Found at #{i}"
ep_objs << obj.name
end
end
end
puts "\n"
puts "Looking up the objects in the OpenStudio.idd to see if they have the field"
puts "=========================================================================="
os_factory = OpenStudio::IddFileAndFactoryWrapper.new("OpenStudio".to_IddFileType)
not_found_obj = []
not_found_field = []
found_field = []
ep_objs.each do |ep_obj_name|
os_obj_name = "OS:#{ep_obj_name}"
os_obj = os_factory.getObject(os_obj_name)
if os_obj.empty?
puts "Couldn't find #{ep_obj_name} in the IDD"
not_found_obj << ep_obj_name
next
end
os_obj = os_obj.get
is_found = false
os_obj.numFields.times do |i|
if os_obj.getField(i).get.name == field_name
puts "#{os_obj.name} - Found at #{i}"
is_found = true
break
end
end
if !is_found
puts "Found object #{os_obj_name} but doesn't have the field"
not_found_field << os_obj_name
else
found_field << os_obj_name
end
end
|
jmarrec
added a commit
that referenced
this issue
May 12, 2020
Insert Minimum Outdoor Dry-Bulb Temperature for Compressor Operation
jmarrec
added a commit
that referenced
this issue
May 12, 2020
jmarrec
added a commit
that referenced
this issue
May 12, 2020
jmarrec
added a commit
that referenced
this issue
May 12, 2020
jmarrec
added a commit
that referenced
this issue
May 13, 2020
Insert Minimum Outdoor Dry-Bulb Temperature for Compressor Operation
jmarrec
added a commit
that referenced
this issue
May 13, 2020
jmarrec
added a commit
that referenced
this issue
May 13, 2020
jmarrec
added a commit
that referenced
this issue
May 13, 2020
jmarrec
added a commit
that referenced
this issue
May 13, 2020
* Added double getter, isDefaulted, setter and resetter * Added to Model Test * Added VersionTranslation for inserted field * Added VersionTranslation test * Added new field to the FT and RT * Added a FT test * RT test can't be done, the RT exists but it's not in use
jmarrec
added a commit
that referenced
this issue
May 13, 2020
* Added double getter, isDefaulted, setter and resetter * Added to Model Test * Added VersionTranslation for inserted field * Added VersionTranslation test * Added new field to the FT * Added a FT test * RT doesn't exist at all
jmarrec
added a commit
that referenced
this issue
May 13, 2020
* Added double getter, isDefaulted, setter and resetter * Added to Model Test * Added VersionTranslation for inserted field * Added VersionTranslation test * Added new field to the FT * Added a FT test * RT doesn't exist at all
jmarrec
added a commit
that referenced
this issue
May 13, 2020
* Added double getter, isDefaulted, setter and resetter * Added to Model Test * Added VersionTranslation for inserted field * Added VersionTranslation test * Added new field to the FT * Added a FT test * RT doesn't exist at all
jmarrec
added a commit
that referenced
this issue
May 13, 2020
* Added double getter, isDefaulted, setter and resetter * Added to Model Test * Added VersionTranslation for inserted field * Added VersionTranslation test * Added new field to the FT * Added a FT test * RT doesn't exist at all
20 tasks
jmarrec
added a commit
that referenced
this issue
May 15, 2020
Insert Minimum Outdoor Dry-Bulb Temperature for Compressor Operation
jmarrec
added a commit
that referenced
this issue
May 15, 2020
jmarrec
added a commit
that referenced
this issue
May 15, 2020
jmarrec
added a commit
that referenced
this issue
May 15, 2020
jmarrec
added a commit
that referenced
this issue
May 15, 2020
* Added double getter, isDefaulted, setter and resetter * Added to Model Test * Added VersionTranslation for inserted field * Added VersionTranslation test * Added new field to the FT and RT * Added a FT test * RT test can't be done, the RT exists but it's not in use
jmarrec
added a commit
that referenced
this issue
May 15, 2020
* Added double getter, isDefaulted, setter and resetter * Added to Model Test * Added VersionTranslation for inserted field * Added VersionTranslation test * Added new field to the FT * Added a FT test * RT doesn't exist at all
jmarrec
added a commit
that referenced
this issue
May 15, 2020
* Added double getter, isDefaulted, setter and resetter * Added to Model Test * Added VersionTranslation for inserted field * Added VersionTranslation test * Added new field to the FT * Added a FT test * RT doesn't exist at all
jmarrec
added a commit
that referenced
this issue
May 15, 2020
* Added double getter, isDefaulted, setter and resetter * Added to Model Test * Added VersionTranslation for inserted field * Added VersionTranslation test * Added new field to the FT * Added a FT test * RT doesn't exist at all
jmarrec
added a commit
that referenced
this issue
May 15, 2020
* Added double getter, isDefaulted, setter and resetter * Added to Model Test * Added VersionTranslation for inserted field * Added VersionTranslation test * Added new field to the FT * Added a FT test * RT doesn't exist at all
tijcolem
added a commit
that referenced
this issue
May 18, 2020
Fix #3976 - Add 'Minimum Outdoor Dry-Bulb Temperature for Compressor Operation' to all Coil:Cooling:DX:XXX objects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add function for DX Cooling coil (CoilCoolingDXSingleSpeed or other DX cooling coils) to set the lower cutoff temperature, EnergyPlus has this field, but OpenStudio does not have a method to access and change this field.
@joseph-robertson and @jmarrec this is high priority. I'm not sure which of you is more loaded, but can one of you pick this up and remove the other assignee?
The text was updated successfully, but these errors were encountered: