remove memfix-controller #528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So this is a just a watchdog that kills pid of Passenger RubyApp if the mem exceeds a threshold? |
|
@tijcolem exactly. to my knowledge there wasnt one. |
|
I'm good with this change. I think the script can also be changed to warn in logs about exceeding memory thresholds. |
brianlball
added a commit
that referenced
this pull request
Nov 25, 2019
remove memfix-controller reviewed in #528
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to remove this. This zombie's a server cluster when it executes and makes it unrecoverable. If new issues arise after removing this (so far they havent on NRcan / P+W branches) then those issues should be diagnosed properly and not do something like this.