Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove memfix-controller #527

Merged
merged 1 commit into from
Nov 25, 2019
Merged

remove memfix-controller #527

merged 1 commit into from
Nov 25, 2019

Conversation

brianlball
Copy link
Contributor

We need to remove this. This zombie's a server cluster when it executes and makes it unrecoverable. If new issues arise after removing this (so far they havent on NRcan / P+W branches) then those issues should be diagnosed properly and not do something like this.

@brianlball
Copy link
Contributor Author

#348

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.09%) to 66.862% when pulling c1fcb54 on memfix-dev into 2b168e3 on develop.

@tijcolem
Copy link
Contributor

I had a comment on #528 that applies to this as well.

@brianlball
Copy link
Contributor Author

reviewed in #528

@brianlball brianlball merged commit dd4c8e8 into develop Nov 25, 2019
@brianlball brianlball deleted the memfix-dev branch November 25, 2019 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants