PMV follow up #8561

xuanluo113 · 2021-02-25T00:53:07Z

Pull request overview

This PR fixes several follow up for the PMV Enhancement feature in Issue #8573. Please see the reply below.

Using the new example file 1ZoneUncontrolled_Win_ASH55_Thermal_Comfort with all of the thermal comfort-related schedules blank, This is the err output:
   ** Severe  ** GetInternalHeatGains: People="ZONE ONE PEOPLE", blank Work Efficiency Schedule Name is required for this item.
   ** Severe  ** GetInternalHeatGains: People="ZONE ONE PEOPLE", invalid Clothing Insulation Schedule Name entered=
   ** Severe  ** GetInternalHeatGains: People="ZONE ONE PEOPLE", blank Air Velocity Schedule Name is required for this item.
   ** Severe  ** GetInternalHeatGains: People="ZONE ONE PEOPLE", blank Ankle Level Air Velocity Schedule Name is required for this item.
   **  Fatal  ** GetInternalHeatGains: Errors found in Getting Internal Gains Input, Program Stopped
Nothing in the errors here indicates that these are required for certain thermal comfort models.
1ZoneUncontrolled_Win_ASH55_Thermal_Comfort-blankschedules.idf.txt

Detailed error messages were added.

New example file 1ZoneUncontrolled_Win_ASH55_Thermal_Comfort throws this warning:
   ** Warning ** Ankle draft PPD calculations are only applicable for relative air velocity is below 0.2 m/s,
   **   ~~~   ** and the subject’s metabolic rate and clothing level should be kept below 1.3 met and 0.7 clo.
   **   ~~~   ** PPD at ankle draft will be set to -1.0 if if these conditions are not met.
These limits should be mentioned in the I/O Reference for the ANKLEDRAFTASH55 report option and mentioned again in the description of "Zone Thermal Comfort ASHRAE 55 Ankle Draft PPD". If it's documented, the warning isn't necessary. If you want to keep the warning, it should list the current values of the air velocity, metabolic rate, and clothing level in the first warning, and then generate recurring warnings to count how often this occurs.

The documents were updated, and recurring warnings were also added.

The I/O Reference for People field "Thermal Comfort Model Type" could use more details about the new options. It would be good to reformat this using the description method.
\begin{description}
  \item[OptionA] Stuff about option A.
  \item[OptionB] Stuff about option B
\end{description}

Descritions with items were added to the I/O Reference for People field "Thermal Comfort Model Type".

These new output variables need descriptions in the I/O Ref.

  Zone,Average,Zone Thermal Comfort ASHRAE 55 Elevated Air Speed Cooling Effect {[}C{]}
  Zone,Average,Zone Thermal Comfort ASHRAE 55 Elevated Air Speed Cooling Effect Adjusted PMV {[]}
  Zone,Average,Zone Thermal Comfort ASHRAE 55 Elevated Air Speed Cooling Effect Adjusted PPD {[]}
  Zone,Average,Zone Thermal Comfort ASHRAE 55 Ankle Draft PPD {[]}

Fixed.

Declarations of constants in ThermalComfort.cc (lines 798:814) - can these be constexpr?
Real64 const CloFac(0.25);

Fixed.

Add a figure explanation to the engineering reference describing the range of ankle draft risk.

Modified in the EngRef.

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

Reviewer

This will not be exhaustively relevant to every PR.

…elop

xuanluo113 · 2021-02-25T02:06:43Z

@mjwitte This bug fixing branch is ready for review.

mjwitte · 2021-02-25T14:51:17Z

...ring-reference/src/simulation-models-encyclopedic-reference-005/occupant-thermal-comfort.tex

-This equation is only applicable for \(v_{r} < 0.2 m/s\) . And the subject’s metabolic rate and clothing level should be kept below 1.3 met and 0.7 clo, respectively. Warnings would be thrown if these conditions are not met.
+This equation is only applicable for \(v_{r} < 0.2 m/s\) . And the subject’s metabolic rate and clothing level should be kept below 1.3 met and 0.7 clo, respectively. PPD at ankle draft will be set to -1.0 if if these conditions are not met.
+
+It should be noted that the metrics only measures the predicted percentage dissatisfied on the sensation of draft. PPD_AD levels at various air speeds and thermal sensations are depicted in Figure~\ref{fig:ankle-draft-ppd}


Look here at the files page in the pull request. There are some LaTeX warnings. Another subscript that needs \( ... \).

@mjwitte Thanks! Fixed.

mjwitte · 2021-02-26T17:56:28Z

...ring-reference/src/simulation-models-encyclopedic-reference-005/occupant-thermal-comfort.tex

@@ -1165,11 +1165,11 @@ \subsubsection{Description of the model and algorithm}\label{description-of-the-

 \subsection{ASHRAE 55 Elevated Air Speed Cooling Effect Model}\label{elevated-air-speed-ce-model}

-ASHRAE Standard 55-2017 Section 5.3 requires that the Elevated Air Speed Comfort Zone Method be used when average air speed Va is greater than 0.10 m/s. The method provides cooling credit for elevated air velocity in the space. The method can be used to evaluate passive cooling technologies such as natural ventilation, ceiling fan, and portable fan.
+ASHRAE Standard 55-2017 Section 5.3 requires that the Elevated Air Speed Comfort Zone Method be used when average air speed \(V_{a}\) is greater than 0.10 m/s. The method provides cooling credit for elevated air velocity in the space. The method can be used to evaluate passive cooling technologies such as natural ventilation, ceiling fan, and portable fan.


Very minor question. Here Va is upper case for air speed, but the other air speeds below are all lower-case v. Is that intentional?

mjwitte · 2021-02-26T18:05:22Z

doc/input-output-reference/src/overview/group-internal-gains-people-lights-other.tex

+
+\paragraph{Zone Thermal Comfort ASHRAE 55 Elevated Air Speed Cooling Effect Adjusted PMV}\label{zone-thermal-comfort-ashrae55-elevated-air-speed-cooling-effect-adjusted-pmv}
+
+This field is the \"predicted mean vote\" (PMV) calculated using the Fanger PMV model, adjusted by the ASHRAE 55 Elevated Air Speed Cooling Effect. The Cooling Effect adjusted PMV for an environment with elevated average air speed is calculated using the adjusted average air temperature, the adjusted radiant temperature, and still air (0.1 m/s). 


predicted is rendering as p̈redicted . Use the smart-quote characters (see existing entries further up): ``predicted mean vote'' (2 characters before and after). Same problem in the next two descriptions.

mjwitte · 2021-02-26T18:17:29Z

src/EnergyPlus/ThermalComfort.cc

-                    ShowContinueError(state,"PPD at ankle draft will be set to -1.0 if if these conditions are not met.");
-                    state.dataThermalComforts->FirstTimeAnkleDraftWarning = false;
+                if (RelAirVel >= 0.2) {
+                    ShowRecurringWarningErrorAtEnd(state, "Relative air velocity is above 0.2 m/s in Ankle draft PPD calculations. PPD at ankle draft will be set to -1.0.",


Thanks for adding these warnings. If I'm following correctly, all of these triggers (air velocity, metabolic rate, and clothing level) are user inputs, correct? So, maybe these warnings aren't so important, because this is likely the user's intent. How about wrapping all of these with if (state.dataGlobal->DisplayExtraWarnings) ? Sorry to keep changing my mind here.

Just to be clear, my suggestion is to have one if (state.dataGlobal->DisplayExtraWarnings) statement before line 1215 that skips all three of these warning checks.

…-follow-up

mjwitte

@xuanluo113 Doc changes look good. Assuming CI comes back green, this is ready to merge.

jmythms · 2021-03-01T22:59:53Z

Tested locally, everything looks good. There will be an .err diff in the upcoming CI result, which is expected due to silencing the warnings. Tried merging latest develop branch to this and built it locally, no conflicts. Thanks @xuanluo113, @mjwitte.

@Myoldmopar

xuanluo113 added 10 commits December 6, 2020 09:46

merge

379db08

Merge branch 'develop' of https://github.com/NREL/EnergyPlus into dev…

c1edf1d

…elop

Merge branch 'develop' of https://github.com/NREL/EnergyPlus into dev…

e2f9130

…elop

Merge branch 'develop' of https://github.com/NREL/EnergyPlus into dev…

121120f

…elop

merge

c72d3fa

merge

684e4c7

Merge branch 'develop' of https://github.com/NREL/EnergyPlus into dev…

b8b445b

…elop

Merge branch 'develop' of https://github.com/NREL/EnergyPlus into dev…

5d7f14c

…elop

address comments

034c0f8

address comments part 2

c9f020e

xuanluo113 added Defect Includes code to repair a defect in EnergyPlus Documentation Related primarily on the LaTeX-based EnergyPlus documentation labels Feb 25, 2021

xuanluo113 added this to the EnergyPlus 9.5.0 milestone Feb 25, 2021

xuanluo113 self-assigned this Feb 25, 2021

xuanluo113 linked an issue Feb 25, 2021 that may be closed by this pull request

PMV Improvements Follow-up #8537

Closed

3 tasks

xuanluo113 added 2 commits February 24, 2021 18:01

more documents

d6b4472

cmake

24267ce

xuanluo113 requested a review from mjwitte February 25, 2021 02:06

mjwitte reviewed Feb 25, 2021

View reviewed changes

fix a document

c653eb7

mjwitte reviewed Feb 26, 2021

View reviewed changes

mjwitte marked this pull request as ready for review February 26, 2021 18:26

xuanluo113 added 2 commits March 1, 2021 10:17

Merge branch 'develop' of https://github.com/NREL/EnergyPlus into pmv…

0f4ff6e

…-follow-up

address more comments

55c3309

mjwitte approved these changes Mar 1, 2021

View reviewed changes

jmythms merged commit b9bfac2 into develop Mar 1, 2021

jmythms deleted the pmv-follow-up branch March 1, 2021 23:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PMV follow up #8561

PMV follow up #8561

xuanluo113 commented Feb 25, 2021 •

edited by mjwitte

Loading

xuanluo113 commented Feb 25, 2021

mjwitte Feb 25, 2021

xuanluo113 Feb 25, 2021

mjwitte Feb 26, 2021

mjwitte Feb 26, 2021

mjwitte Feb 26, 2021

mjwitte Feb 27, 2021

mjwitte left a comment

jmythms commented Mar 1, 2021


		\paragraph{Zone Thermal Comfort ASHRAE 55 Elevated Air Speed Cooling Effect Adjusted PMV}\label{zone-thermal-comfort-ashrae55-elevated-air-speed-cooling-effect-adjusted-pmv}

		This field is the \"predicted mean vote\" (PMV) calculated using the Fanger PMV model, adjusted by the ASHRAE 55 Elevated Air Speed Cooling Effect. The Cooling Effect adjusted PMV for an environment with elevated average air speed is calculated using the adjusted average air temperature, the adjusted radiant temperature, and still air (0.1 m/s).

PMV follow up #8561

PMV follow up #8561

Conversation

xuanluo113 commented Feb 25, 2021 • edited by mjwitte Loading

Pull request overview

Pull Request Author

Reviewer

xuanluo113 commented Feb 25, 2021

mjwitte Feb 25, 2021

Choose a reason for hiding this comment

xuanluo113 Feb 25, 2021

Choose a reason for hiding this comment

mjwitte Feb 26, 2021

Choose a reason for hiding this comment

mjwitte Feb 26, 2021

Choose a reason for hiding this comment

mjwitte Feb 26, 2021

Choose a reason for hiding this comment

mjwitte Feb 27, 2021

Choose a reason for hiding this comment

mjwitte left a comment

Choose a reason for hiding this comment

jmythms commented Mar 1, 2021

xuanluo113 commented Feb 25, 2021 •

edited by mjwitte

Loading