Implement additional chiller part load curve type #4727

rongpengzhang · 2015-02-13T19:24:30Z

@Introduction of the feature:
Chillers with variable speed drive (VSD Chillers) on compressors, reset control of entering condenser water temperature and leaving chilled water temperature can operate much more efficiently at part load conditions. An additional part-load performance curve type is proposed for such chillers in EnergyPlus. The new curve type is a modification to the existing curve and can model performance of VSD chillers more accurately.

@summary of the changes:
(1) 2 existing CC files and 2 existing HH files are updated
(2) IDD file is modified
(3) 1 new IDF example file is added
(4) 10 existing IDF example files are updated

Changes include the following: (1) 1 IDD file (2) 2 CC files (3) 2 HH files

Changes include the following: (1) 1 new IDF file is added (ChillerPartLoadCurve_RefBldgLargeOfficeNew2004_Chicago.idf) (2) 10 existing IDF files are modified

Padding issues corrected

Hopefully diff comes up clean this time; this was troublesome

…LBNLChillerCurve-2

Myoldmopar · 2015-02-18T16:52:01Z

OK, @rongpengzhang I pushed up some changes. These include:

Updating transition source to accomodate the IDD changes. This was a big burden, and I had to for some reason clean up a bunch of Transition source. Anyway, the idfs are coming out clean and look great.
Passing the relevant idfs through Transition to make sure they are clean and only show relevant diffs. There are Sizing:System diffs in the field names only, which I think is because the idfs on develop were slightly out of date and hadn't been passed through Transition (looks like it went in with PR Revised supply air flow rate fields in multiple IDD objects #4642)
Merging develop into this branch to ensure we are up to date to avoid any regression issues.

Let's wait and see what the robots say about this last commit (beefc61), and if everything looks good, we should be very close to merging. Can you upload the doc changes (IORef, EngRef) to a new folder in here?

rongpengzhang · 2015-02-18T17:28:10Z

Thanks, @Myoldmopar I can tell the transition updating is tough work. Good job!

I will upload the IORef and EngRef ASAP.

Myoldmopar · 2015-02-18T18:13:59Z

@rongpengzhang Verified that the one failure should be cleaned up with the updated reference temperature. This should be good to go with beefb3d and the doc changes over in BuildSupport.

@mjwitte This was proposed and approved a long time ago, so it's not worth a whole lot of scrutiny, but if you wouldn't mind taking a minute and glancing over, for example, the IDD changes, I would appreciate it.

Myoldmopar · 2015-02-19T14:26:06Z

@rongpengzhang OK, things are looking good. As expected, the cppcheck, unit test coverage, and integration test coverage all came back fully green. And also as expected, the Ubuntu and Mac builds with regression tests are coming back with one diff, the idf we changed. The WIndows machine is really busy, but I'll give it a little time this morning to get one result in. This will give some more time to get the doc changes uploaded to BuildSupport anyway.

Myoldmopar · 2015-02-19T14:28:04Z

Oh, and @rongpengzhang, in your pull request at the top, you @ tagged two random people: introduction and summary. If you want titles, just use # or ## or ###, don't use the @ symbol. (Formatting tips here)

mjwitte · 2015-02-19T15:21:38Z

idd/Energy+.idd.in

+       \note Calculated based on dT*, Tdev* and PLR
+       \note curve = a + b*(dT*) + c*(dT*)**2 + d*PLR + e*PLR**2 + f*(dT*)*PLR + g*(dT*)**3
+       \note + h*PLR**3 + i*(dT*)**2*PLR + j*(dT*)*PLR**2 + k*(dT*)**2*PLR**2 + l*(Tdev*)*PLR**3
+       \note Tdev = Leaving Chilled Water Temperature � Reference Chilled Water Temperature


@rongpengzhang There is a special character in this line - shows as a box on github.

rongpengzhang · 2015-02-19T17:31:52Z

@Myoldmopar I'm happy that things are going well as what we expected. Thanks for the formatting tips, I didn't know there are better choices to make the title bold ~

@mjwitte Thanks a lot for the detailed IDD check and suggestion!
I will take care of the special character issue.
Yes, "BiVariateTables" should be kept there.
The updated IDD file will be uploaded very soon.

Myoldmopar · 2015-02-19T17:51:19Z

@rongpengzhang CI looks great. Once you are done with the IDD changes, I'll update the transition one more time per @mjwitte's comments, along with the idfs. We'll have to let CI have one last pass to make sure the IDD changes don't accidentally mess up anything, but then merge.

(1) IDD files updated (2) 1 cc file and 1 hh file are updated, due to IDD updates (3) 1 IDF file updated

rongpengzhang · 2015-02-19T18:36:56Z

@Myoldmopar I have updated the IDD file taking @mjwitte 's comments. Can you let CI to run another test (cc and idf files are also changed due to idd updates)

mjwitte · 2015-02-19T19:34:54Z

@rongpengzhang There's new warnings with HospitalLowEnergy?
@Myoldmopar I'm going to make a few more minor tweaks to the IDD - shouldn't impact any test runs.

mjwitte · 2015-02-19T19:56:20Z

src/EnergyPlus/ChillerReformulatedEIR.cc

-			if ( lAlphaFieldBlanks( 5 ) ) {
+
+			//Check the type of part-load curves implemented: 1_LeavingCondenserWaterTemperature, 2_Lift    zrp_Aug2014
+			if ( SameString( PartLoadCurveType, "LeavingCondenserWaterTemperature" ) && SameString( GetCurveType( ElecReformEIRChiller( EIRChillerNum ).ChillerEIRFPLR ), "BICUBIC" ) ) {


@rongpengzhang Didn't notice these before. These if blocks need to be expanded to include the valid table types. Some components allow any form a curve as long as it has the same number of independent variables. Do you feel strongly that this should only allow these specific curve forms? e.g. Should biquadratic be illegal, or just a warning, or completely acceptable? @mmAtTs @Myoldmopar @EnergyArchmage Comments?

@mjwitte
It seems that the users are required to use "BICUBIC" , rather than other curve types, to describe this specific curve ("Electric Input to Cooling Output Ratio Function of Part Load Ratio Curve"). Details can be found in the following iDD sections. Please let me know if you think "warning" is better. Of course, table types need to be added if we keep using "severe error"

Chiller:Electric:ReformulatedEIR,
A5 , \field Electric Input to Cooling Output Ratio Function of Part Load Ratio Curve Name
\type object-list
\object-list BicubicCurves
\object-list BiVariateTables
\object-list ChillerPartLoadWithLiftCurves
\note two types of part-load curves are available: BicubicCurves or ChillerPartLoadWithLiftCurves
\note Type 1: BicubicCurves;
\note Calculated based on LCT and PLR
\note curve = a + b_LCT + c_LCT2 + d_PLR + e_PLR2 + f_LCT_PLR + g_0 + h_PLR3
\note + i_0 + j_0
\note PLR = part load ratio (cooling load/steady state capacity)
\note LCT = leaving condenser fluid temperature(C)
\note Type 2: ChillerPartLoadWithLiftCurves
\note Calculated based on dT_, Tdev_ and PLR
\note curve = a + b_(dT_) + c_(dT_)2 + d_PLR + e_PLR2 + f_(dT_)PLR + g(dT*)3
\note + h_PLR__3 + i_(dT_)2_PLR + j(dT)PLR__2 + k(dT_)__2_PLR2 + l_(Tdev_)*PLR3

I guess since the enforcement is actually on BiCubic curves or tables, and if you enter BiCubic as the table type, this enforcement is fine. Or am I missing something now?

Myoldmopar · 2015-02-19T20:24:22Z

@mjwitte No, there are fewer warnings in HospitalLowEnergy. The lines in the error file are now removed.

@mjwitte I'm guessing any two-independent-variable form is allowable, including tables, curves, and any shape. Thus, it should be loosened up.

@rongpengzhang I will update the transition source per @mjwitte and check that in. Then the curve type check in GetInput needs to be resolved. Hopefully that's that last issue.

mjwitte · 2015-02-19T20:29:40Z

@Myoldmopar Whoops - sorry - still not used to the color green meaning deleted. Error reduction is good.
@rongpengzhang I've committed suggested IDD changes. Language about curve types may need to change slightly now from "Curve object type should be " to "Recommended curve object types are:" ?

rongpengzhang · 2015-02-19T20:30:17Z

@Myoldmopar I agree that this should be consistent with other similar cases in EnergyPlus. If the tradition is to consider it a "waning", it is fine with me.

rongpengzhang · 2015-02-19T20:32:46Z

@mjwitte Thanks for the suggestion. I will do that

mjwitte · 2015-02-19T20:53:49Z

@rongpengzhang @Myoldmopar Arrrgh. I generally forget that tables can have a secondary curve type associated with them. To me, the power of tables is to not use a specific curve form (i.e. Interpolation Type != EvaluateCurveToLimits). @mmAtTs Is our expert on validation of curve types. What are the other components doing?

Myoldmopar · 2015-02-19T21:24:09Z

@rongpengzhang @mjwitte Updated transition source to write out the default value rather than a blank. I'm not going to retransition those idfs. They will get re-transitioned before release, plus I bet other idd changes are looming anyway. So those fields will show up then. I think @mmAtTs can confirm that the code is doing the right thing on the table, and then this should be OK.

Thanks for all the review time and conversation everyone.

mitchute · 2015-02-19T21:28:14Z

@mjwitte It's been a while since I looked at the curves, but if I remember correctly we found out that the CurveManager is doing a good job of sorting out the right tables for the right types of curves. So long as the curves are referenced as they normally are throughout (which I think they are), I think this should be fine.

Myoldmopar · 2015-02-19T22:01:59Z

OK, CI should pick it up and hopefully overnight it will come out all clean and we can merge it in tomorrow morning.

Changes by mjwitte.

rongpengzhang · 2015-02-20T02:39:55Z

@Myoldmopar I have put the EngRef and IORef modifications into this folder: EnergyPlusBuildSupport/docs/src/mods/for_2015_03_release/ZRP-66516336-LBNLChillerCurve/

Myoldmopar · 2015-02-20T16:33:20Z

Thanks @rongpengzhang for the doc changes, I'll look them over. I ran the new example file locally and found some very minor messages (1 unused construction, etc.). I'm not worried about that.

@mjwitte Does ExpandObjects write out reformulated EIR chillers? If so, this will have to have an ExpandObjects update too, I guess. Sorry I just thought about that, but

ExpandObjects changes?

is at the bottom of my review checklist... Moving it toward the top so it's not an afterthought.

mjwitte · 2015-02-20T16:43:09Z

@Myoldmopar Reformulated EIR chiller is referenced, so there will be a few lines of code that need to change.

Myoldmopar · 2015-02-20T17:00:37Z

Hooray! OK, well I want this in today, so I will take a crack at making the changes in ExpandObjects. I'll tag you for review if you can just glance over the ExpandObjects changes there.

mjwitte · 2015-02-20T17:04:18Z

@Myoldmopar Search epfilter.f90 for 'reformulated'. You just need to change some integer values to make sure they line up with the new object. Also that "25" at the end of the long function call.

rongpengzhang · 2015-02-20T17:10:12Z

@Myoldmopar We are almost there! Quite happy to see the delivery of my first EPlus product ~ Thanks @mjwitte and @mmAtTs for all the review and support! Cheers ~

…dObjects for REIRChiller

Myoldmopar · 2015-02-20T17:14:50Z

@mjwitte OK, I updated the integers to account for the new field being inserted. The new field is @ A4, which is overall argument # 9. So all the node indices were incremented by 1, plus the last field index. Should be good to go I would guess.

With CI catching back up, if there are no more commits, we should have sufficient results to determine whether it is mergeable this afternoon. Thanks for the help.

Oh, and since a separate PR went in this morning I'll merge develop right quick.

Additional Chiller Part Load Curve Type

rongpengzhang and others added 7 commits February 13, 2015 09:25

Codes Changes for the new chiller curve

f550fd4

Changes include the following: (1) 1 IDD file (2) 2 CC files (3) 2 HH files

Example files for the new chiller curve

f9b71e7

Changes include the following: (1) 1 new IDF file is added (ChillerPartLoadCurve_RefBldgLargeOfficeNew2004_Chicago.idf) (2) 10 existing IDF files are modified

Add transition changes for chiller eir curve

beef835

Minor formatting changes

fec7eed

Padding issues corrected

Updated transition and idfs;

beef4b4

Hopefully diff comes up clean this time; this was troublesome

Merge branch 'LBNLChillerCurve-2' of github.com:NREL/EnergyPlus into …

beef6ae

…LBNLChillerCurve-2

Merge remote-tracking branch 'origin/develop' into LBNLChillerCurve-2

beefc61

Update reference temperature in HospitalLowEnergy

beefb3d

mjwitte reviewed Feb 19, 2015
View reviewed changes

IDD file updated

80d8639

(1) IDD files updated (2) 1 cc file and 1 hh file are updated, due to IDD updates (3) 1 IDF file updated

Special character

941b6f4

mjwitte reviewed Feb 19, 2015
View reviewed changes

IDD edits for new Chiller:ReformulatedEIR curve type

e705649

Fix transition to write the default key in the eir chiller

beef8da

rongpengzhang added 2 commits February 19, 2015 13:29

Minor IDD changes

bc60a00

minor change

41fe969

IDD edits for new Chiller:ReformulatedEIR curve type

ec78441

Changes by mjwitte.

Add new test file to CMakeLists for integration testing; Update Expan…

beef75d

…dObjects for REIRChiller

Merge remote-tracking branch 'origin/develop' into LBNLChillerCurve-2

beef9df

Myoldmopar self-assigned this Feb 21, 2015

Myoldmopar added a commit that referenced this pull request Feb 21, 2015

Merge pull request #4727 from NREL/LBNLChillerCurve-2

5882b18

Additional Chiller Part Load Curve Type

Myoldmopar merged commit 5882b18 into develop Feb 21, 2015

Myoldmopar deleted the LBNLChillerCurve-2 branch February 21, 2015 01:36

Myoldmopar changed the title ~~Additional Chiller Part Load Curve Type~~ Implement additional chiller part load curve type Mar 7, 2015

Myoldmopar added the NewFeature Includes code to add a new feature to EnergyPlus label Mar 9, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement additional chiller part load curve type #4727

Implement additional chiller part load curve type #4727

rongpengzhang commented Feb 13, 2015

Myoldmopar commented Feb 18, 2015

rongpengzhang commented Feb 18, 2015

Myoldmopar commented Feb 18, 2015

Myoldmopar commented Feb 19, 2015

Myoldmopar commented Feb 19, 2015

mjwitte Feb 19, 2015

rongpengzhang commented Feb 19, 2015

Myoldmopar commented Feb 19, 2015

rongpengzhang commented Feb 19, 2015

mjwitte commented Feb 19, 2015

mjwitte Feb 19, 2015

rongpengzhang Feb 19, 2015

Myoldmopar Feb 19, 2015

Myoldmopar commented Feb 19, 2015

mjwitte commented Feb 19, 2015

rongpengzhang commented Feb 19, 2015

rongpengzhang commented Feb 19, 2015

mjwitte commented Feb 19, 2015

Myoldmopar commented Feb 19, 2015

mitchute commented Feb 19, 2015

Myoldmopar commented Feb 19, 2015

rongpengzhang commented Feb 20, 2015

Myoldmopar commented Feb 20, 2015

mjwitte commented Feb 20, 2015

Myoldmopar commented Feb 20, 2015

mjwitte commented Feb 20, 2015

rongpengzhang commented Feb 20, 2015

Myoldmopar commented Feb 20, 2015

Implement additional chiller part load curve type #4727

Implement additional chiller part load curve type #4727

Conversation

rongpengzhang commented Feb 13, 2015

Myoldmopar commented Feb 18, 2015

rongpengzhang commented Feb 18, 2015

Myoldmopar commented Feb 18, 2015

Myoldmopar commented Feb 19, 2015

Myoldmopar commented Feb 19, 2015

mjwitte Feb 19, 2015

Choose a reason for hiding this comment

rongpengzhang commented Feb 19, 2015

Myoldmopar commented Feb 19, 2015

rongpengzhang commented Feb 19, 2015

mjwitte commented Feb 19, 2015

mjwitte Feb 19, 2015

Choose a reason for hiding this comment

rongpengzhang Feb 19, 2015

Choose a reason for hiding this comment

Myoldmopar Feb 19, 2015

Choose a reason for hiding this comment

Myoldmopar commented Feb 19, 2015

mjwitte commented Feb 19, 2015

rongpengzhang commented Feb 19, 2015

rongpengzhang commented Feb 19, 2015

mjwitte commented Feb 19, 2015

Myoldmopar commented Feb 19, 2015

mitchute commented Feb 19, 2015

Myoldmopar commented Feb 19, 2015

rongpengzhang commented Feb 20, 2015

Myoldmopar commented Feb 20, 2015

mjwitte commented Feb 20, 2015

Myoldmopar commented Feb 20, 2015

mjwitte commented Feb 20, 2015

rongpengzhang commented Feb 20, 2015

Myoldmopar commented Feb 20, 2015