Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revised supply air flow rate fields in multiple IDD objects #4642

Conversation

rraustad
Copy link
Contributor

Used "cooling", "heating", or "no load" as initial text in field name and removed lengthy trailing text (e.g., During Cooling Operation, When No Cooling is Needed, No Cooling or Heating is Required, etc.)

Any comments before I update the IORef?

  • Revise IDD field names
  • Revise IO Reference document
  • Compare IDD and IO Ref

…g", "heating", or "no load" as initial text in field name and removed lengthy trailing text (e.g., During Cooling Operation, When No Cooling is Needed, No Cooling or Heating is Required, etc.)
@mjwitte
Copy link
Contributor

mjwitte commented Dec 20, 2014

@rraustad These look good. The field names are much more readable and concise. Affected more places than I had expected. So, one question for clarification, with FractionOfAutosizedCoolingAirflow, the base value that the fraction is applied to is the cooling design flow rate from the sizing calcs, correct? So, let's say the sizing calcs come up with 0.05 m3/s, but the Cooling Supply Air Flow Rate Method = SupplyAirFlowRate and the Cooling Supply Air Flow Rate is specified at 0.04 m3/s. Now if the Heating or No Load method is FractionOfAutosizedCoolingAirflow, will it be based on 0.05 or 0.04?

@rraustad
Copy link
Contributor Author

@mjwitte Correct on the "autosized" basis. I guess we need a FractionofHardsizedCooling(Heating)AirFlow. This is good though since I did want to include more choices in the sizing choices. I will be starting with the AirloopHVAC:UnitarySystem to continue with sizing consolidations. I'll see what I can do given the tight budget.

@nrel-bot
Copy link

@mjwitte @rraustad @lgentile it has been 7 days since this pull request was last updated.

3 similar comments
@nrel-bot
Copy link

nrel-bot commented Jan 4, 2015

@mjwitte @rraustad @lgentile it has been 7 days since this pull request was last updated.

@nrel-bot
Copy link

@mjwitte @rraustad @lgentile it has been 7 days since this pull request was last updated.

@nrel-bot
Copy link

@mjwitte @rraustad @lgentile it has been 7 days since this pull request was last updated.

@rraustad
Copy link
Contributor Author

IO Ref checked into https://github.com/NREL/EnergyPlusBuildSupport/tree/master/docs/src/mods/for_2015_03_release/RR-Update%20IO%20Ref%20Supply%20Air%20Flow%20Rate%20fields%20and%20other%20associated%20text

This is the full IO Ref since many objects were modified. If there is a problem with merging, I guess I am on the hook to revise this document into smaller sections.

Closing pull request.

@rraustad rraustad closed this Jan 20, 2015
@rraustad
Copy link
Contributor Author

This needs to stay open until the IDD is merged into develop.

@rraustad rraustad reopened this Jan 20, 2015
@nrel-bot
Copy link

@mjwitte @rraustad @lgentile it has been 7 days since this pull request was last updated.

@mjwitte
Copy link
Contributor

mjwitte commented Feb 1, 2015

@rraustad IDD looks good - sorry for the delay in reviewing. Merging. Will review docs next.

mjwitte added a commit that referenced this pull request Feb 1, 2015
…eld-Fraction-of-Autosized-Design-Cooling-Supply-Air-Flow-Rate

Revised supply air flow rate fields in multiple objects. Used "cooling",...
@mjwitte mjwitte merged commit 8e2c240 into develop Feb 1, 2015
@mjwitte mjwitte deleted the 84003340-4599-SizingSystem-N18,-field-Fraction-of-Autosized-Design-Cooling-Supply-Air-Flow-Rate branch February 1, 2015 22:13
@Myoldmopar Myoldmopar changed the title Revised supply air flow rate fields in multiple objects. Used "cooling",... Revised supply air flow rate fields in multiple IDD objects Mar 7, 2015
@Myoldmopar Myoldmopar added the Defect Includes code to repair a defect in EnergyPlus label Mar 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Defect Includes code to repair a defect in EnergyPlus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants