-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix Super high COP in VRFFluidTCtrl model #10752
base: develop
Are you sure you want to change the base?
Commits on Sep 19, 2024
-
fix TotalHeatingCapacity, it missed cycling ratio
Yujie Xu committedSep 19, 2024 Configuration menu - View commit details
-
Copy full SHA for e4dcfb7 - Browse repository at this point
Copy the full SHA e4dcfb7View commit details
Commits on Sep 20, 2024
-
Consider cycling in defrost power
Yujie Xu committedSep 20, 2024 Configuration menu - View commit details
-
Copy full SHA for 6c9b079 - Browse repository at this point
Copy the full SHA 6c9b079View commit details -
Merge remote-tracking branch 'origin/develop' into fixVRFhighCOP
Yujie Xu committedSep 20, 2024 4Configuration menu - View commit details
-
Copy full SHA for 5556102 - Browse repository at this point
Copy the full SHA 5556102View commit details -
Here VRFRTF is not initialized, don't multiply here to defrost
Yujie Xu committedSep 20, 2024 2Configuration menu - View commit details
-
Copy full SHA for d08b956 - Browse repository at this point
Copy the full SHA d08b956View commit details -
move defrost RTF adjust out of the if block
so that when the outdoor conditions cause a non-zero defrost power, AND the system if off, defrost power would be set to zero.
Yujie Xu committedSep 20, 2024 4Configuration menu - View commit details
-
Copy full SHA for 61760ed - Browse repository at this point
Copy the full SHA 61760edView commit details
Commits on Sep 23, 2024
-
move defrostPower adjustment after VRFRTF is initialized
Yujie Xu committedSep 23, 2024 4Configuration menu - View commit details
-
Copy full SHA for 1828d18 - Browse repository at this point
Copy the full SHA 1828d18View commit details
Commits on Sep 24, 2024
-
Pdischarge is the compressor discharge pressure, this->CompMaxDeltaP is the maximum compressor pressure rise Pdischarge - this->CompMaxDeltaP is minimum compressor suction pressure RefMinPe is minimum refrigerant evaporating pressure These two terms are both lower bounds of the suction pressure CapMinPe should be no less than both of them, so CapMinPe should be max of the two LB, not min
Yujie Xu committedSep 24, 2024 4Configuration menu - View commit details
-
Copy full SHA for 3c62414 - Browse repository at this point
Copy the full SHA 3c62414View commit details
Commits on Sep 25, 2024
-
fix warning of Cooling Coil Type SI to IP unit conversion
Yujie Xu committedSep 25, 2024 4Configuration menu - View commit details
-
Copy full SHA for 335cf0f - Browse repository at this point
Copy the full SHA 335cf0fView commit details -
resolve err counter integer overflow
the error message counter is a sum of all previous counter values it overflows to negative non-recurring warning keeps showing up after the overflow use the counter, not the sum of counter in the predicate
Yujie Xu committedSep 25, 2024 4Configuration menu - View commit details
-
Copy full SHA for 54be7dc - Browse repository at this point
Copy the full SHA 54be7dcView commit details -
fix another overflow place, use this->errors[].count as counter
Yujie Xu committedSep 25, 2024 4Configuration menu - View commit details
-
Copy full SHA for 0d49054 - Browse repository at this point
Copy the full SHA 0d49054View commit details
Commits on Sep 26, 2024
-
Yujie Xu committed
Sep 26, 2024 Configuration menu - View commit details
-
Copy full SHA for d5f8c45 - Browse repository at this point
Copy the full SHA d5f8c45View commit details
Commits on Oct 1, 2024
-
Merge remote-tracking branch 'origin/develop' into fixVRFhighCOP
Yujie Xu committedOct 1, 2024 4Configuration menu - View commit details
-
Copy full SHA for 55c51df - Browse repository at this point
Copy the full SHA 55c51dfView commit details
Commits on Oct 7, 2024
-
Merge remote-tracking branch 'origin/develop' into fixVRFhighCOP
Yujie Xu committedOct 7, 2024 4Configuration menu - View commit details
-
Copy full SHA for aba83c7 - Browse repository at this point
Copy the full SHA aba83c7View commit details