Skip to content

Commit

Permalink
Fix min pressure lower bound
Browse files Browse the repository at this point in the history
Pdischarge is the compressor discharge pressure,
this->CompMaxDeltaP is the maximum compressor pressure rise
Pdischarge - this->CompMaxDeltaP is minimum compressor suction pressure

RefMinPe is minimum refrigerant evaporating pressure

These two terms are both lower bounds of the suction pressure

CapMinPe should be no less than both of them, so CapMinPe should be max of the
two LB, not min
  • Loading branch information
Yujie Xu committed Sep 24, 2024
1 parent 1828d18 commit 3c62414
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions src/EnergyPlus/HVACVariableRefrigerantFlow.cc
Original file line number Diff line number Diff line change
Expand Up @@ -11591,7 +11591,8 @@ void VRFCondenserEquipment::CalcVRFCondenser_FluidTCtrl(EnergyPlusData &state, c
Tdischarge = this->refrig->getSatTemperature(state, max(min(Pdischarge, RefPHigh), RefPLow), RoutineName);

// Evaporative capacity ranges_Min
CapMinPe = min(Pdischarge - this->CompMaxDeltaP, RefMinPe);
// suction pressure lower bound need to be no less than both terms in the following
CapMinPe = max(Pdischarge - this->CompMaxDeltaP, RefMinPe);
CapMinTe = this->refrig->getSatTemperature(state, max(min(CapMinPe, RefPHigh), RefPLow), RoutineName);
CompEvaporatingCAPSpdMin = this->CoffEvapCap * this->RatedEvapCapacity * CurveValue(state, this->OUCoolingCAPFT(1), Tdischarge, CapMinTe);
CompEvaporatingPWRSpdMin = this->RatedCompPower * CurveValue(state, this->OUCoolingPWRFT(1), Tdischarge, CapMinTe);
Expand Down Expand Up @@ -11663,8 +11664,7 @@ void VRFCondenserEquipment::CalcVRFCondenser_FluidTCtrl(EnergyPlusData &state, c
Tdischarge,
h_IU_cond_out_ave,
this->IUCondensingTemp,
// Te can't be smaller than user input lower bound
max(this->IUEvapTempLow, CapMinTe),
CapMinTe,
Tfs,
Pipe_Q_h,
Q_c_OU,
Expand Down

4 comments on commit 3c62414

@nrel-bot-2c
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixVRFhighCOP (Unknown) - x86_64-Linux-Ubuntu-22.04-gcc-11.4: OK (2913 of 2913 tests passed, 0 test warnings)

Build Badge Test Badge

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixVRFhighCOP (Unknown) - Win64-Windows-10-VisualStudio-16: OK (2891 of 2891 tests passed, 0 test warnings)

Build Badge Test Badge

@nrel-bot-2b
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixVRFhighCOP (Unknown) - x86_64-Linux-Ubuntu-22.04-gcc-11.4-IntegrationCoverage-RelWithDebInfo: OK (799 of 799 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixVRFhighCOP (Unknown) - x86_64-Linux-Ubuntu-22.04-gcc-11.4-UnitTestsCoverage-RelWithDebInfo: OK (2097 of 2097 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

Please sign in to comment.