Fix Fan:ZoneExhaust AFN validation
#10661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lymereJ
added
Defect
lymereJ
commented
Aug 14, 2024
Comment on lines
+11228
to
+11236
| } | ||
| if (!found) { | ||
| ShowSevereError(m_state, format("{}Fan:ZoneExhaust is not defined in {}", RoutineName, CurrentModuleObject)); | ||
| ShowContinueError( | ||
| m_state, | ||
| format("The inlet node of the {} Fan:ZoneExhaust is not defined in the {}'s ZoneHVAC:EquipmentConnections", | ||
| m_state.dataZoneEquip->ZoneEquipList(j).EquipName, | ||
| m_state.dataZoneEquip->ZoneEquipConfig(j).ZoneName)); | ||
| ErrorsFound = true; |
There was a problem hiding this comment.
Moved this verification so it can be done after iterating through all exhaust nodes.
Comment on lines
+19767
to
+19780
| " ZoneHVAC:Dehumidifier:DX,", | ||
| " North Zone Dehumidifier, !- Name", | ||
| " always_avail, !- Availability Schedule Name", | ||
| " Zone3DehumidifierInlet, !- Air Inlet Node Name", | ||
| " Dehumidifier Outlet Node,!- Air Outlet Node Name", | ||
| " 50.16, !- Rated Water Removal {L/day}", | ||
| " 3.412, !- Rated Energy Factor {L/kWh}", | ||
| " 0.12036, !- Rated Air Flow Rate {m3/s}", | ||
| " ZoneDehumidWaterRemoval, !- Water Removal Curve Name", | ||
| " ZoneDehumidEnergyFactor, !- Energy Factor Curve Name", | ||
| " ZoneDehumidPLFFPLR, !- Part Load Fraction Correlation Curve Name", | ||
| " 10.0, !- Minimum Dry-Bulb Temperature for Dehumidifier Operation {C}", | ||
| " 32.0, !- Maximum Dry-Bulb Temperature for Dehumidifier Operation {C}", | ||
| " 0.0; !- Off-Cycle Parasitic Electric Load {W}", |
There was a problem hiding this comment.
Add a dehumidifier to this test to create the same situation as the defect file (multiple exhaust nodes). The defect file uses a VRF terminal.
There was a problem hiding this comment.
Nice job just modifying an existing test here.
Comment on lines
+19830
to
+19835
|
|
||
| // Check that the validation fails if the AFN exhaust fan is not well setup | ||
| int exhaustFanInletNodeIndex = state->afn->MultizoneCompExhaustFanData(1).InletNode; | ||
| state->afn->MultizoneCompExhaustFanData(1).InletNode = 6; | ||
| state->afn->ValidateExhaustFanInputOneTimeFlag = true; | ||
| EXPECT_THROW(state->afn->validate_exhaust_fan_input(), std::runtime_error); |
There was a problem hiding this comment.
Mess with the exhaust fan node to make sure that the if statement that was moved still creates a fatal error.
Myoldmopar
approved these changes
Aug 21, 2024
Comment on lines
+11228
to
+11236
| } | ||
| if (!found) { | ||
| ShowSevereError(m_state, format("{}Fan:ZoneExhaust is not defined in {}", RoutineName, CurrentModuleObject)); | ||
| ShowContinueError( | ||
| m_state, | ||
| format("The inlet node of the {} Fan:ZoneExhaust is not defined in the {}'s ZoneHVAC:EquipmentConnections", | ||
| m_state.dataZoneEquip->ZoneEquipList(j).EquipName, | ||
| m_state.dataZoneEquip->ZoneEquipConfig(j).ZoneName)); | ||
| ErrorsFound = true; |
Comment on lines
+19767
to
+19780
| " ZoneHVAC:Dehumidifier:DX,", | ||
| " North Zone Dehumidifier, !- Name", | ||
| " always_avail, !- Availability Schedule Name", | ||
| " Zone3DehumidifierInlet, !- Air Inlet Node Name", | ||
| " Dehumidifier Outlet Node,!- Air Outlet Node Name", | ||
| " 50.16, !- Rated Water Removal {L/day}", | ||
| " 3.412, !- Rated Energy Factor {L/kWh}", | ||
| " 0.12036, !- Rated Air Flow Rate {m3/s}", | ||
| " ZoneDehumidWaterRemoval, !- Water Removal Curve Name", | ||
| " ZoneDehumidEnergyFactor, !- Energy Factor Curve Name", | ||
| " ZoneDehumidPLFFPLR, !- Part Load Fraction Correlation Curve Name", | ||
| " 10.0, !- Minimum Dry-Bulb Temperature for Dehumidifier Operation {C}", | ||
| " 32.0, !- Maximum Dry-Bulb Temperature for Dehumidifier Operation {C}", | ||
| " 0.0; !- Off-Cycle Parasitic Electric Load {W}", |
There was a problem hiding this comment.
Nice job just modifying an existing test here.
|
No objections, and it's still clean when I pull in develop and test. Thanks @lymereJ, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request overview
Fan:ZoneExhaustnode validation issue with Airflow Network #10660Pull Request Author
Add to this list or remove from it as applicable. This is a simple templated set of guidelines.
Reviewer
This will not be exhaustively relevant to every PR.