Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fan:ZoneExhaust node validation issue with Airflow Network #10660

Closed
1 of 3 tasks
lymereJ opened this issue Aug 14, 2024 · 0 comments · Fixed by #10661
Closed
1 of 3 tasks

Fan:ZoneExhaust node validation issue with Airflow Network #10660

lymereJ opened this issue Aug 14, 2024 · 0 comments · Fixed by #10661
Assignees
Labels
AirflowNetwork Related primarily on airflow-network portions of the codebase Defect Includes code to repair a defect in EnergyPlus

Comments

@lymereJ
Copy link
Collaborator

lymereJ commented Aug 14, 2024

Issue overview

The defect file shows some validation issue with a Fan:ZoneExhaust. Its inlet node is part of a NodeList. It looks like a if statement is misplaced and triggers an error if the fan inlet node isn't the first one listed in the NodeList object, see below.

for (int k = 1; k <= m_state.dataZoneEquip->ZoneEquipConfig(j).NumExhaustNodes; ++k) {
for (int i = 1; i <= AirflowNetworkNumOfExhFan; ++i) {
if (m_state.dataZoneEquip->ZoneEquipConfig(j).ExhaustNode(k) == MultizoneCompExhaustFanData(i).InletNode) {
MultizoneCompExhaustFanData(i).EPlusZoneNum = j;
found = true;
}
}
if (!found) {
ShowSevereError(m_state, format("{}Fan:ZoneExhaust is not defined in {}", RoutineName, CurrentModuleObject));
ShowContinueError(m_state,
"Zone Air Exhaust Node in ZoneHVAC:EquipmentConnections =" +
m_state.dataLoopNodes->NodeID(m_state.dataZoneEquip->ZoneEquipConfig(j).ExhaustNode(k)));
ErrorsFound = true;
}

Details

Some additional details for this issue (if relevant):

  • Platform: Windows 10
  • Version of EnergyPlus: Latest develop

Checklist

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

  • Defect file added: US+SF+CZ5B+hp+slab+IECC_2021_VRF.zip
  • Ticket added to EnergyPlus Defect Complexity (Github Project)
  • Pull request cre
    ated (the pull request will have additional tasks related to reviewing changes that fix this defect)
@lymereJ lymereJ added Defect Includes code to repair a defect in EnergyPlus AirflowNetwork Related primarily on airflow-network portions of the codebase labels Aug 14, 2024
@lymereJ lymereJ self-assigned this Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AirflowNetwork Related primarily on airflow-network portions of the codebase Defect Includes code to repair a defect in EnergyPlus
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant