Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support of umol/m2-s in IDF Editor for IndoorLivingWall support #10414

Merged
merged 2 commits into from
Feb 28, 2024
Merged

Add support of umol/m2-s in IDF Editor for IndoorLivingWall support #10414

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4f36bf8
Clean up units in IDD and add conversion factor
JasonGlazer Feb 26, 2024
c2b5947
Update idfeditor source and binary
JasonGlazer Feb 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified bin/IDFEditor/IDFEditor.exe
View file
Open in desktop
Binary file not shown.
7 changes: 3 additions & 4 deletions idd/Energy+.idd.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,6 +311,7 @@
! percent/K => percent/F 0.555555555555556
! person/m2 => person/ft2 0.0928939733269818
! s/m => s/ft 0.3048
! umol/m2-s => umol/ft2-s 0.09290304
! V/K => V/F 0.555555555555556
! W => Btu/h 3.4121412858518
! W/((m3/s)-Pa) => W/((gal/min)-ftH20) 0.188582274697355
Expand Down Expand Up @@ -369,7 +370,6 @@
! kgWater/kgDryAir
! kmol
! kmol/s
! umol/m2s
! m3/m3
! micron
! minutes
Expand All @@ -380,7 +380,6 @@
! ppm
! rev/min
! s
! umol_m2s
! V
! VA
! W/m2, deg C or cd/m2
Expand Down Expand Up @@ -22727,9 +22726,9 @@ IndoorLivingWall,
N2 , \field LED Nominal Intensity
\note The value represents photosynthetic photon flux density (PPFD) of LED grow light.
\note PPFD is measured in micro-mole per m2 per second (umol_m2s) which establishes exactly how many photosynthetically active radiation (PAR) photons are landing on a specific area.
\units umol_m2s
\units umol/m2-s
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think is purely an editorial change since \units I think is only used by IDF Edtior

\type real
\ip-units umol_m2s
\ip-units umol/ft2-s
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change to using / instead of _ and using ft2 for the \ip-units should only impact IDF Editor

N3 , \field LED Nominal Power
\note This field defines nominal total LED power for an indoor living wall system.
\units W
Expand Down
6 changes: 3 additions & 3 deletions src/IDF_Editor/IDFEd-project.VBP
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,12 +27,12 @@ HelpContextID="0"
CompatibleMode="0"
MajorVer=1
MinorVer=5
RevisionVer=3
RevisionVer=4
AutoIncrementVer=0
ServerSupportFiles=0
VersionComments="1.53"
VersionComments="1.54"
VersionCompanyName="GARD Analytics"
VersionLegalCopyright="(c) 2000-2017 GARD Analytics"
VersionLegalCopyright="(c) 2000-2024 GARD Analytics"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😮

CompilationType=0
OptimizationType=0
FavorPentiumPro(tm)=0
Expand Down
7 changes: 5 additions & 2 deletions src/IDF_Editor/IDFEditMain.bas
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ Attribute VB_Name = "IDFMain"
' command line argument /idd:iddfilename
'

Public Const ver = "1.53" 'current version of IDFEditor - less than 1 is a beta
Public Const ver = "1.54" 'current version of IDFEditor - less than 1 is a beta
Option Explicit
Option Base 1

Expand Down Expand Up @@ -628,7 +628,7 @@ End Sub
'-----------------------------------------------------------------------------
Sub setUnits()
Dim i As Long
maxUsedConvUnits = 155
maxUsedConvUnits = 156
unitsDimensionless = 56
ReDim convUnits(maxUsedConvUnits)
' the following is pasted in from the unitsIPandSI.xls file
Expand Down Expand Up @@ -787,6 +787,7 @@ convUnits(152).siName = "m3/hr-m2"
convUnits(153).siName = "m3/hr"
convUnits(154).siName = "W/((m3/s)-Pa)"
convUnits(155).siName = "W/m2, deg C or cd/m2"
convUnits(156).siName = "umol/m2-s"

convUnits(1).ipName = "ft"
convUnits(2).ipName = "in"
Expand Down Expand Up @@ -943,6 +944,7 @@ convUnits(152).ipName = "gal/hr-ft2"
convUnits(153).ipName = "gal/hr"
convUnits(154).ipName = "W/((ft3/min)-inH2O)"
convUnits(155).ipName = "unknown"
convUnits(156).ipName = "umol/ft2-s"

convUnits(1).mult = 3.28083989501312
convUnits(2).mult = 39.3700787401575
Expand Down Expand Up @@ -1099,6 +1101,7 @@ convUnits(152).mult = 24.5423853466941
convUnits(153).mult = 264.172037284185
convUnits(154).mult = 0.117556910599482
convUnits(155).mult = 1
convUnits(156).mult = 0.09290304

convUnits(7).offset = 32
convUnits(19).offset = 7.686
Expand Down
4 changes: 2 additions & 2 deletions src/IDF_Editor/about.frm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ Begin VB.Form About
Begin VB.Label lblVersion
Alignment = 1 'Right Justify
AutoSize = -1 'True
Caption = "Version 1.53"
Caption = "Version 1.54"
BeginProperty Font
Name = "Arial"
Size = 12
Expand All @@ -92,7 +92,7 @@ Begin VB.Form About
Strikethrough = 0 'False
EndProperty
Height = 285
Left = 1710
Left = 1680
TabIndex = 1
Top = 960
Width = 1410
Expand Down
Loading