Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support of umol/m2-s in IDF Editor for IndoorLivingWall support #10414

Merged
merged 2 commits into from
Feb 28, 2024
Merged

Add support of umol/m2-s in IDF Editor for IndoorLivingWall support #10414

merged 2 commits into from
Feb 28, 2024

Conversation

JasonGlazer
Copy link
Contributor

Pull request overview

  • Fixes missing unit dialog in IDF Editor

see #10385 (comment)

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
  • Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
  • Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
  • If any diffs are expected, author must demonstrate they are justified using plots and descriptions
  • If changes fix a defect, the fix should be demonstrated in plots and descriptions
  • If any defect files are updated to a more recent version, upload new versions here or on DevSupport
  • If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
  • If structural output changes, add to output rules file and add OutputChange label
  • If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies

Reviewer

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs

@JasonGlazer JasonGlazer added the Defect Includes code to repair a defect in EnergyPlus label Feb 26, 2024
@JasonGlazer JasonGlazer self-assigned this Feb 26, 2024
@JasonGlazer JasonGlazer mentioned this pull request Feb 26, 2024
Merged
20 tasks
@JasonGlazer JasonGlazer added this to the EnergyPlus 24.1 milestone Feb 26, 2024
JasonGlazer
JasonGlazer commented Feb 26, 2024
View reviewed changes
idd/Energy+.idd.in
@@ -22727,9 +22726,9 @@ IndoorLivingWall,
N2 , \field LED Nominal Intensity
\note The value represents photosynthetic photon flux density (PPFD) of LED grow light.
\note PPFD is measured in micro-mole per m2 per second (umol_m2s) which establishes exactly how many photosynthetically active radiation (PAR) photons are landing on a specific area.
\units umol_m2s
\units umol/m2-s
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think is purely an editorial change since \units I think is only used by IDF Edtior

JasonGlazer
JasonGlazer commented Feb 26, 2024
View reviewed changes
idd/Energy+.idd.in
\type real
\ip-units umol_m2s
\ip-units umol/ft2-s
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change to using / instead of _ and using ft2 for the \ip-units should only impact IDF Editor

Myoldmopar
Myoldmopar approved these changes Feb 28, 2024
View reviewed changes
Copy link
Member

@Myoldmopar Myoldmopar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good here.

src/IDF_Editor/IDFEd-project.VBP
VersionCompanyName="GARD Analytics"
VersionLegalCopyright="(c) 2000-2017 GARD Analytics"
VersionLegalCopyright="(c) 2000-2024 GARD Analytics"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😮

@Myoldmopar
Copy link
Member

Is this still a draft @JasonGlazer ? I trust that you executed IDF Editor to make sure it was happy...

@JasonGlazer JasonGlazer marked this pull request as ready for review February 28, 2024 12:48
@JasonGlazer
Copy link
Contributor Author

Because of the minuscule change to the IDD, I wanted to let CI run and clear everything. It is ready to go.

@Myoldmopar
Copy link
Member

👍 thanks @JasonGlazer, merging.

@Myoldmopar Myoldmopar merged commit 1edbc13 into develop Feb 28, 2024
17 checks passed
@Myoldmopar Myoldmopar deleted the add_idfeditor_unit_umol-m2s branch February 28, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Myoldmopar Myoldmopar Myoldmopar approved these changes

@mjwitte mjwitte Awaiting requested review from mjwitte

Assignees

@JasonGlazer JasonGlazer

Labels
Defect Includes code to repair a defect in EnergyPlus
Projects
None yet
Milestone
EnergyPlus 24.1
Development

Successfully merging this pull request may close these issues.
6 participants
@JasonGlazer @Myoldmopar @nrel-bot @nrel-bot-3 @nrel-bot-2b @nrel-bot-2c