Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Debug option on Camera service doesn't seem to work #194

Closed
feens opened this issue Jan 3, 2020 · 18 comments
Closed

[BUG] Debug option on Camera service doesn't seem to work #194

feens opened this issue Jan 3, 2020 · 18 comments
Labels
bug 🐛 There is at least high chance that it is a bug!

Comments

@feens
Copy link

feens commented Jan 3, 2020

Describe the bug
I'm having issues getting camera service to work with an RTSP stream. I've tried to debug this but all I get is ERROR: FFmpeg exited with code 1, and no further details, which isn't that helpful.

I'm running 0.8.0, and I've also tried changing my log level to debug in settings.js.

What's also interesting: the service seemed to be generating snapshots fine.
@feens feens added the bug 🐛 There is at least high chance that it is a bug! label Jan 3, 2020
@Shaquu
Copy link
Member

Shaquu commented Jan 3, 2020

You can run node-red in debug mode. It might help to see what is an error.

@feens
Copy link
Author

feens commented Jan 4, 2020

I'm not sure where this magical "debug" mode is for node-red. Reading the docs, all I can find is the option to set which log-level to use. As noted above, I tried debug which didn't give me any more information for the camera stuff. I even tried trace, which still gives me the same output of ERROR: FFmpeg exited with code 1 when I try and access the stream in the Home app.

@Shaquu
Copy link
Member

Shaquu commented Jan 4, 2020 •
edited
Loading

How can I generate Debug logs?

Stop your node-red instance and start it again using the following command:
DEBUG=NRCHKB,NRCHKB_Camera node-red

This should output detailed information regarding everything in the homekit context.

Also read #16

@radokristof
Copy link
Contributor

@Shaquu I also have a problem and I know why.
I want to use video codec copy but I can't clear the video filter (and copy and video filter cannot be used together) because the default is scale=1280:720. Can I somehow override this?

@radokristof
Copy link
Contributor

Did a quick and dirty solution, but this should be corrected and video-filter (and maybe all additional parameters) should be optional not required (now shows required in the Node-RED GUI) and also if no parameter specified, don't add defaults to the stream...

@Shaquu
Copy link
Member

Shaquu commented Jan 11, 2020 •
edited
Loading

Did a quick and dirty solution, but this

Would like to make a PR?

@radokristof
Copy link
Contributor

The solution involves that it now overwrites the vf local variable with an empty array (so now you can't supply video filters). However I think I can make them optional.

@feens
Copy link
Author

feens commented Jan 15, 2020

Closing this as I was able to fix it...thanks!

@feens feens closed this as completed Jan 15, 2020
@Shaquu
Copy link
Member

Shaquu commented Jan 15, 2020

I know it's closed but @radokristof still please make a PR :)

@radokristof
Copy link
Contributor

I'm on it :) However I have a little time right now (I will have more next week) and I didn't figured out a neat way to do this... I'm not a JavaScript expert :)

@Shaquu Shaquu reopened this Jan 16, 2020
@Shaquu
Copy link
Member

Shaquu commented Jan 16, 2020

I will open this Issue to not forget about it.

@feens
Copy link
Author

feens commented Jan 18, 2020

@Shaquu unrelated, but didn't want to open an issue quite yet. I've noticed a weird issue while adding a second camera: both cameras are showing the same image as a still image. One of my cameras creates its own, so I have a URL provide for the still image source option. The second camera doesn't have this, so that option is blank. Both have Content selected for the snapshot option

@Shaquu
Copy link
Member

Shaquu commented Jan 19, 2020

@feens One bridge can have only one camera.
We should add a better info to readme and block adding second and more.

@feens
Copy link
Author

feens commented Jan 20, 2020 •
edited
Loading

@Shaquu oh interesting. Is that a limitation on HomeKit itself? It's interesting because the feeds both work.

@crxporter
Copy link
Member

Is that a limitation on HomeKit itself

Yes. Homekit protocol mandates one camera per bridge.

@Shaquu Shaquu mentioned this issue Jan 28, 2020
Merged
Shaquu added a commit that referenced this issue Jan 29, 2020
@Shaquu
1.0.0-dev.8
b22f095 
-   Video Filter value in Camera Control is now optional [#194](#194) (can be empty, before it was generated if was empty)
-   Removed updateReachability as it is deprecated (and doesn't make a difference)
@Shaquu Shaquu mentioned this issue Jan 29, 2020
Merged
@Shaquu
Copy link
Member

Shaquu commented Jan 29, 2020

@radokristof would you test latest dev if it solve the problem?
Now video filter should be able to be cleared and will not generate default value underneath.

Shaquu added a commit that referenced this issue Feb 23, 2020
@Shaquu
Merge pull request #163 from NRCHKB/dev
a97b126 
## [1.0.0] - 2020.02.23

Lost backward compatibility. In order to make it work read this [notice](#163 (comment)).

### Fixed

-   Node id macify algorithm changed [#170](#170)
-   Corrections regarding issue [#12](#12) so that changes can be deployed without restarting node-red
-   Automatically creating a new service and replacing the old one if the service type changed
-   Automatically replacing an accessory with a new one if the accessory information changes (e.g. Name, Manufacturer, ...)
-   Video Filter value in Camera Control is now optional [#194](#194) (can be empty, before it was generated if was empty)
-   Removed updateReachability as it is deprecated (and doesn't make a difference)

### Added

-   After Service selection in node configuration Category will be automatically set to default for Service
-   Interface Name for Camera Service configuration
-   Support for new TV Remote services
-   Now first output is for onChange, second for onSet and third for camera snapshot. [#200](#200)
-   Sponsor Button on repository page

### Changed

-   Accessory Category in node configuration moved under Service selection
-   Clarify NO_RESPONSE in README
-   Update node-red version in dependencies
-   Camera Service source code to match newest improvements in homebridge-camera-ffmpeg
-   Update to latest HAP-NodeJS
-   Removed unnecessary accessory category from service node
-   Removed fields Manufacturer, Serial Number and Model from linked service nodes
-   Moved eslint and prettier configuration to package.json
-   Added automatic linting on pre-commit


Thanks to all contributors!
@radokristof @NorthernMan54 @gotofoo 

And thanks to those who also helped in testing!
@crxporter @sjorge
@Shaquu Shaquu mentioned this issue Feb 25, 2020
Closed
@andreypopov
Copy link

andreypopov commented Feb 25, 2020 •
edited
Loading

2020-02-25_23-44-58

2020-02-25_23-44-42

remove required field please

@Shaquu
Copy link
Member

Shaquu commented Mar 1, 2020 •
edited
Loading

@andreypopov @radokristof

Video Filter should now be fully optional in 1.0.3 (just released).
Let's discuss further problems in #214

To debug camera problem in NRCHKB with node-red you have to:

  • start node-red in debug mode via DEBUG=NRCHKB* node-red
  • tick debug option in Camera Control service node

@Shaquu Shaquu closed this as completed Mar 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐛 There is at least high chance that it is a bug!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@andreypopov @Shaquu @feens @radokristof @crxporter