Skip to content

Commit

Permalink
Merge pull request #163 from NRCHKB/dev
Browse files Browse the repository at this point in the history
## [1.0.0] - 2020.02.23

Lost backward compatibility. In order to make it work read this [notice](#163 (comment)).

### Fixed

-   Node id macify algorithm changed [#170](#170)
-   Corrections regarding issue [#12](#12) so that changes can be deployed without restarting node-red
-   Automatically creating a new service and replacing the old one if the service type changed
-   Automatically replacing an accessory with a new one if the accessory information changes (e.g. Name, Manufacturer, ...)
-   Video Filter value in Camera Control is now optional [#194](#194) (can be empty, before it was generated if was empty)
-   Removed updateReachability as it is deprecated (and doesn't make a difference)

### Added

-   After Service selection in node configuration Category will be automatically set to default for Service
-   Interface Name for Camera Service configuration
-   Support for new TV Remote services
-   Now first output is for onChange, second for onSet and third for camera snapshot. [#200](#200)
-   Sponsor Button on repository page

### Changed

-   Accessory Category in node configuration moved under Service selection
-   Clarify NO_RESPONSE in README
-   Update node-red version in dependencies
-   Camera Service source code to match newest improvements in homebridge-camera-ffmpeg
-   Update to latest HAP-NodeJS
-   Removed unnecessary accessory category from service node
-   Removed fields Manufacturer, Serial Number and Model from linked service nodes
-   Moved eslint and prettier configuration to package.json
-   Added automatic linting on pre-commit


Thanks to all contributors!
@radokristof @NorthernMan54 @gotofoo 

And thanks to those who also helped in testing!
@crxporter @sjorge
  • Loading branch information
Shaquu authored Feb 23, 2020
2 parents 72d07f3 + 9514a1d commit a97b126
Show file tree
Hide file tree
Showing 26 changed files with 1,735 additions and 1,188 deletions.
27 changes: 0 additions & 27 deletions .eslintrc.json

This file was deleted.

27 changes: 18 additions & 9 deletions .github/ISSUE_TEMPLATE/bug_report.md
Original file line number Diff line number Diff line change
@@ -1,17 +1,15 @@
---
name: Bug report
about: Create a report to help us improve
title: "[BUG]"
labels: 'bug :bug:'
assignees: ''

---

**Describe the bug**
title: '[BUG] *short_bug_description*'
labels: bug :bug:, help wanted
assignees: Shaquu
---**Describe the bug**
A clear and concise description of what the bug is.

**To Reproduce**
Steps to reproduce the behavior:

1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
Expand All @@ -22,9 +20,20 @@ A clear and concise description of what you expected to happen.

**Flow**
If applicable, add flow to help explain and reproduce your problem.
You can export flow using _Menu > Export > Clipboard_ in _node-red_ dashboard.

**Screenshots**
If applicable, add screenshots to help explain your problem.

**Additional context**
Add any other context about the problem here.
**Versions**
Replace _x.y.z_ in a table with versions you have in environment afflicted by a bug.

| | version |
| :--------- | ------: |
| _Node JS_ | x.y.z |
| _node-red_ | x.y.z |
| _NRCHKB_ | x.y.z |

---

[//]: # 'NRCHKB is a short name for node-red-contrib-homekit-bridged*'
9 changes: 3 additions & 6 deletions .github/ISSUE_TEMPLATE/feature_request.md
Original file line number Diff line number Diff line change
@@ -1,13 +1,10 @@
---
name: Feature request
about: Suggest an idea for this project
title: "[FEATURE]"
title: '[FEATURE] *short_feature_name*'
labels: 'enhancement :+1:'
assignees: ''

---

**Is your feature request related to a problem? Please describe.**
assignees: Shaquu
---**Is your feature request related to a problem? Please describe.**
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

**Describe the solution you'd like**
Expand Down
32 changes: 32 additions & 0 deletions .github/workflows/publish-dev.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
name: Publish nrchkb@dev

on:
push:
branches:
- dev

jobs:
test:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v1
- uses: actions/setup-node@v1
with:
version: 10
- run: |
npm install
npm run build --if-present
npm test
publish-npm:
needs: test
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v1
- uses: actions/setup-node@v1
with:
node-version: 10
registry-url: https://registry.npmjs.org/
- run: npm publish --tag dev
env:
NODE_AUTH_TOKEN: ${{secrets.NODE_TKN}}
60 changes: 30 additions & 30 deletions .github/workflows/publish.yml
Original file line number Diff line number Diff line change
@@ -1,36 +1,36 @@
name: Publish nrchkb

on:
push:
branches:
- master
push:
branches:
- master

jobs:
test:
runs-on: ${{ matrix.os }}
strategy:
matrix:
node_version: [8, 10]
os: [ubuntu-latest, windows-latest, macOS-latest]
steps:
- uses: actions/checkout@v1
- uses: actions/setup-node@v1
with:
version: ${{ matrix.node_version }}
- run: |
npm install
npm run build --if-present
npm test
test:
runs-on: ${{ matrix.os }}
strategy:
matrix:
node_version: [8, 10]
os: [ubuntu-latest, windows-latest, macOS-latest]
steps:
- uses: actions/checkout@v1
- uses: actions/setup-node@v1
with:
version: ${{ matrix.node_version }}
- run: |
npm install
npm run build --if-present
npm test
publish-npm:
needs: test
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v1
- uses: actions/setup-node@v1
with:
node-version: 10
registry-url: https://registry.npmjs.org/
- run: npm publish
env:
NODE_AUTH_TOKEN: ${{secrets.NODE_TKN}}
publish-npm:
needs: test
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v1
- uses: actions/setup-node@v1
with:
node-version: 10
registry-url: https://registry.npmjs.org/
- run: npm publish
env:
NODE_AUTH_TOKEN: ${{secrets.NODE_TKN}}
38 changes: 19 additions & 19 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,22 +3,22 @@ name: Run tests for nrchkb
on: [push, pull_request]

jobs:
build:
runs-on: ${{ matrix.os }}
strategy:
matrix:
node_version: [8, 10]
os: [ubuntu-latest, windows-latest, macOS-latest]
steps:
- uses: actions/checkout@v1
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v1
with:
node-version: ${{ matrix.node-version }}
- name: npm install, build, and test
run: |
npm install
npm run build --if-present
npm test
env:
CI: true
build:
runs-on: ${{ matrix.os }}
strategy:
matrix:
node_version: [8, 10]
os: [ubuntu-latest, windows-latest, macOS-latest]
steps:
- uses: actions/checkout@v1
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v1
with:
node-version: ${{ matrix.node-version }}
- name: npm install, build, and test
run: |
npm install
npm run build --if-present
npm test
env:
CI: true
7 changes: 0 additions & 7 deletions .prettierrc

This file was deleted.

3 changes: 1 addition & 2 deletions .travis.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
sudo: false
language: node_js
node_js:
- "10"
- "8"
- '10'
Loading

0 comments on commit a97b126

Please sign in to comment.