Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump nwis_client version #258

Merged
merged 3 commits into from
Oct 8, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion python/nwis_client/pytest.ini
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
[pytest]
markers =
slow: marks tests as slow (deselect with '-m "not slow"')
asyncio_default_fixture_loop_scope = function
2 changes: 1 addition & 1 deletion python/nwis_client/src/hydrotools/nwis_client/_version.py
Original file line number Diff line number Diff line change
@@ -1 +1 @@
__version__ = "3.3.1"
__version__ = "3.4.0"
8 changes: 4 additions & 4 deletions python/nwis_client/tests/test_nwis.py
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ def text(self):
##### FIXTURES #####

@pytest.fixture(name="IVDataServiceWithTempCache")
def wrap_iv_cache_location_to_temp(loop):
def wrap_iv_cache_location_to_temp(event_loop):
from tempfile import TemporaryDirectory
from pathlib import Path
from functools import partial
Expand Down Expand Up @@ -540,7 +540,7 @@ def test_nwis_client_get_throws_warning_for_kwargs(mocked_iv):
mocked_iv.get(sites=["01189000"], startDt="2022-01-01")

@pytest.mark.slow
def test_nwis_client_cache_path(loop):
def test_nwis_client_cache_path(event_loop):
"""verify that cache directory has configurable location"""
from tempfile import TemporaryDirectory
from pathlib import Path
Expand All @@ -558,7 +558,7 @@ def test_nwis_client_cache_path(loop):


@pytest.mark.slow
def test_nwis_client_context_manager(loop):
def test_nwis_client_context_manager(event_loop):
"""verify that context manager closes resources"""
with iv.IVDataService() as service:
service.get(sites=["01189000"], startDT="2022-01-01")
Expand All @@ -567,7 +567,7 @@ def test_nwis_client_context_manager(loop):
# assert service._restclient._loop.is_closed()


def test_fixes_209(loop, monkeypatch):
def test_fixes_209(event_loop, monkeypatch):
"""
verify that pandas FutureWarning is not raised by `IVDataService.get`. This FutureWarning was
introduced in 1.5.1. see pandas changelog
Expand Down
Loading