Bump nwis_client version
#258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Really odd. The GH action runners say that the tests passed, but looking at the output there was some kind of failure. https://github.com/NOAA-OWP/hydrotools/actions/runs/11239006782/job/31245048101?pr=258#step:6:43 Fatal error on SSL transport
protocol: <asyncio.sslproto.SSLProtocol object at 0x7ff174b7e640>
transport: <_SelectorSocketTransport closing fd=7>
Traceback (most recent call last):
File "/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/asyncio/selector_events.py", line 910, in write
n = self._sock.send(data)
OSError: [Errno 9] Bad file descriptor
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/asyncio/sslproto.py", line 685, in _process_write_backlog
self._transport.write(chunk)
File "/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/asyncio/selector_events.py", line 916, in write
self._fatal_error(exc, 'Fatal write error on socket transport')
File "/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/asyncio/selector_events.py", line 711, in _fatal_error
self._force_close(exc)
File "/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/asyncio/selector_events.py", line 7[23](https://github.com/NOAA-OWP/hydrotools/actions/runs/11239006782/job/31245048101?pr=258#step:6:24), in _force_close
self._loop.call_soon(self._call_connection_lost, exc)
File "/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/asyncio/base_events.py", line 719, in call_soon
self._check_closed()
File "/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/asyncio/base_events.py", line 508, in _check_closed
Error: raise RuntimeError('Event loop is closed') |
|
I've got to pop over to another task for now. I will look at this in a bit. |
`pytest-aiohttp` re-exports `pytest-asyncio`'s `event_loop` fixture as `loop`. `pytest-aiohttp` will remove the `loop` fixture in the future. use the `pytest-asyncio`'s `event_loop` directly. aio-libs/pytest-aiohttp#19
aaraney
force-pushed
the
bump_nwis_client
branch
from
9d3ae43 to
a96e431
Compare
this is annoying... a warning is issued without this present. the change to `pytest-asyncio` was added here: pytest-dev/pytest-asyncio@c74d1c3#diff-b6eecb9684dfb3a8e0ad8e43510999af4dc5dc5d03edaafd7fe6f872b22fe857R211
aaraney
force-pushed
the
bump_nwis_client
branch
from
a96e431 to
e5d66b3
Compare
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump version in preparation for release.