Added NLogBuilder and ASP.NET Core 2 example #191

304NotModified · 2017-10-07T20:37:01Z

added NLogBuilder.ConfigureNLog, Simplify setting up the NLog config #184
added NLogAspNetCoreOptions
auto register: <extensions> not needed anymore in the config, fixes Make <add assembly="NLog.Web.AspNetCore"/> unneeded #187
fix namespaces,
updated docs
added ASP.NET Core 2 example (build on AppVeyor)

codecov · 2017-10-07T20:37:03Z

Codecov Report

Merging #191 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #191   +/-   ##
=====================================
  Coverage      58%    58%           
=====================================
  Files          29     29           
  Lines         386    386           
  Branches       93     93           
=====================================
  Hits          224    224           
  Misses        126    126           
  Partials       36     36

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1509356...1623e85. Read the comment docs.

codecov · 2017-10-07T20:37:03Z

Codecov Report

Merging #191 into master will decrease coverage by 1%.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #191   +/-   ##
=====================================
- Coverage      58%    58%   -1%     
=====================================
  Files          29     29           
  Lines         386    386           
  Branches       93     93           
=====================================
- Hits          224    222    -2     
  Misses        126    126           
- Partials       36     38    +2

Impacted Files	Coverage Δ
...youtRenderers/AspNetRequestCookieLayoutRenderer.cs	`81% <0%> (-4%)`	⬇️
...outRenderers/AspNetLayoutMultiValueRendererBase.cs	`95% <0%> (-2%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1509356...51f8969. Read the comment docs.

added NLogAspNetCoreOptions auto register: <extensions> not needed anymore fix namespaces docs

304NotModified · 2017-10-07T21:25:04Z

examples/ASP.NET Core 2/Visual Studio 2017/ASP.NET Core 2 - VS2017/Program.cs

+        public static void Main(string[] args)
+        {
+            // NLog: setup the logger first to catch all errors
+            var logger = NLogStart.InitLogger("NLog.config");


@snakefoot inspiration for a better names?

InitLogger is very confusing. It almost seem like you are creating a logger named "NLog.config".

Maybe rename NLogStart to NLogBuilder, and rename "InitLogger" to "LoadConfig" where LoadConfig returns NLogBuilder (fluent interface like)

NLogBuilder.LoadConfig("NLog.config").GetCurrentClassLogger()

NLogBuilder.GetCurrentClassLogger()

Be aware that calling GetCurrentClassLogger within NLogBuilder will capture the wrong classname.

NLogBuilder.LoadConfig("NLog.config").GetCurrentClassLogger()

LoadConfig could return the LogFactory, not sure it that's clear. What do you think?

also doubting to call it ConfigureNLog, that consistent with the ConfigureNLog on ILoggingBuilder, (see #185) but maybe consistent is just confusing here.

not sure it that's clear. What do you think?

Actually what you want is just the LogManager-interface, but you want people to perform the registration of AspNetExtensions before loading the config (From file or programmatically). Think it would be easier for all NLog-users if LogManager remained the default goto-place.

Think you want something like ConfigureNLog that just configures everything, and then people can use LogManager from there.

Maybe you could change the RegisterExtendedItems() to attempt loading known good NLog-assemblies. Like NLog.Extended.dll and NLog.Web.dll and NLog.Web.AspNetCore.dll (Maybe it could do some probing of the environment, to detect if there is a high-chance of succesfully loading one of these dlls)

Usually this auto-loading of NLog-dlls works out-of-the-box, but not when using Nuget-package-dlls that reside in different sub-folder.

What's dull about it?

Very hard to call GetCurrentClassLogger() or Flush() on the LoggingConfiguration-object.

well Flush isn't needed in this case? Or do you think it's wise to add it after BuildWebHost?

I can just see that people like the fluent-interface of Serilog, and it requires that you have access to a "powerful" object like the LogFactoy. But yes normally one will just be calling GetCurrentClassLogger().

But I prefer to have 3 stages. Startup - Running - Shutdown. Where Startup is where I load the NLog-config and the Running-stage where I acquire my loggers. Each stage happens at different locations in the code, so I don't need to build the nlog-config and get the logger-interface at the same location. I certainly don't want to load the nlog-config multiple times, only once!

I see serilog fixes this by using something called context, so the same global-logger is used everywhere but one can apply multiple local-context-names at different locations. But I kind of like the NLog-style of the logger-name being captured from the context-class.

We load it once here?

Fluent config would be great indeed. With the json config feature, that's one of the next steps for 4.6/4.7 I think

We load it once here?

Yes but one might think that if I need to get a logger at different place, then I should just do the same (Call LoadConfig/ConfigureNLog and then GetCurrentClassLogger), and then one might be surprised by the side-effects of the config-reload.

Or one might be cheated by the NLog-singleton-behavior, as it is hard to have multiple configs at the same time.

304NotModified · 2017-10-10T21:45:47Z

examples/ASP.NET Core 2/Visual Studio 2017/ASP.NET Core 2 - VS2017/Program.cs

+        public static void Main(string[] args)
+        {
+            // NLog: setup the logger first to catch all errors
+            var logger = NLogBuilder.ConfigureNLog("NLog.config").GetCurrentClassLogger();


@snakefoot updated it! I think is indeed a lot better.

@grokky1 any opinion on this? Do you think this is clear?

The latest changes are good. Looking forward to using this.

@grokky1 the beta is live. Please let me know of you're happy, rtm will be soon then. See also.https://github.com/NLog/NLog.Web/wiki/Getting-started-with-ASP.NET-Core-2

@304NotModified Sorry busy wrapping up a sprint so didn't get a chance, will try soon!!

internal logging

304NotModified added 2 commits October 7, 2017 23:08

added NLogStart.InitLogger

d6d4a70

added NLogAspNetCoreOptions auto register: <extensions> not needed anymore fix namespaces docs

Added ASP.NET Core 2 example

6f861ea

304NotModified force-pushed the example-aspnetcore2 branch from 1623e85 to 6f861ea Compare October 7, 2017 21:10

304NotModified added this to the NLog.Web.AspNetCore 4.5 + NLog.Web 4.5.1 milestone Oct 7, 2017

304NotModified added feature ASP.NET Core 2 labels Oct 7, 2017

304NotModified commented Oct 7, 2017

View reviewed changes

304NotModified mentioned this pull request Oct 9, 2017

LogManager.LogFactory public NLog/NLog#2316

Merged

304NotModified force-pushed the example-aspnetcore2 branch from 5ad5516 to eb5a1e2 Compare October 10, 2017 21:45

304NotModified commented Oct 10, 2017

View reviewed changes

304NotModified changed the title ~~Added InitLogger and ASP.NET Core 2 example~~ Added NLogBuilder and ASP.NET Core 2 example Oct 11, 2017

update with NLogBuilder

51f8969

internal logging

304NotModified force-pushed the example-aspnetcore2 branch from 70ebb9e to 51f8969 Compare October 12, 2017 12:42

304NotModified merged commit 41da1c0 into master Oct 12, 2017

304NotModified deleted the example-aspnetcore2 branch October 12, 2017 14:06

304NotModified mentioned this pull request Oct 12, 2017

Simplify setting up the NLog config #184

Closed

snakefoot added ASP.NET Core ASP.NET Core - all versions and removed ASP.NET Core 2 labels Jan 9, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added NLogBuilder and ASP.NET Core 2 example #191

Added NLogBuilder and ASP.NET Core 2 example #191

304NotModified commented Oct 7, 2017 •

edited

Loading

codecov bot commented Oct 7, 2017

codecov bot commented Oct 7, 2017 •

edited

Loading

304NotModified Oct 7, 2017

snakefoot Oct 7, 2017

snakefoot Oct 7, 2017

304NotModified Oct 8, 2017 •

edited

Loading

snakefoot Oct 8, 2017 •

edited

Loading

snakefoot Oct 9, 2017

304NotModified Oct 9, 2017

snakefoot Oct 9, 2017 •

edited

Loading

304NotModified Oct 9, 2017

snakefoot Oct 9, 2017

304NotModified Oct 10, 2017

grokky1 Oct 11, 2017

304NotModified Oct 12, 2017

grokky1 Oct 16, 2017

Added NLogBuilder and ASP.NET Core 2 example #191

Added NLogBuilder and ASP.NET Core 2 example #191

Conversation

304NotModified commented Oct 7, 2017 • edited Loading

codecov bot commented Oct 7, 2017

Codecov Report

codecov bot commented Oct 7, 2017 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

304NotModified Oct 8, 2017 • edited Loading

Choose a reason for hiding this comment

snakefoot Oct 8, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

snakefoot Oct 9, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

304NotModified commented Oct 7, 2017 •

edited

Loading

codecov bot commented Oct 7, 2017 •

edited

Loading

304NotModified Oct 8, 2017 •

edited

Loading

snakefoot Oct 8, 2017 •

edited

Loading

snakefoot Oct 9, 2017 •

edited

Loading