Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make <add assembly="NLog.Web.AspNetCore"/> unneeded #187

Closed
304NotModified opened this issue Sep 30, 2017 · 3 comments · Fixed by #188 or #191
Closed

Make <add assembly="NLog.Web.AspNetCore"/> unneeded #187

304NotModified opened this issue Sep 30, 2017 · 3 comments · Fixed by #188 or #191
Labels
ASP.NET Core ASP.NET Core - all versions feature
Milestone
NLog.Web.AspNetCo...

Comments

@304NotModified
Copy link
Member

Make

  <extensions>
    <add assembly="NLog.Web.AspNetCore"/>
  </extensions>

Unneeded in the config
@304NotModified
Copy link
Member Author

we need RegisterItemsFromAssembly on ConfigurationItemFactory

@304NotModified 304NotModified mentioned this issue Oct 2, 2017
Merged
@304NotModified 304NotModified reopened this Oct 2, 2017
@304NotModified
Copy link
Member Author

304NotModified commented Oct 2, 2017 •
edited
Loading

doesn't work if we do LogManager.Configuration.Reload();

it should work, as ConfigurationItemFactory.Default won't be set/changed in NLog.

we need to reset, as I couldn't got it working on the example

This was referenced Oct 2, 2017
Closed
Merged
@304NotModified
Copy link
Member Author

fixed for asp.net core 2

@snakefoot snakefoot added feature ASP.NET Core ASP.NET Core - all versions and removed ASP.NET Core 2 labels Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ASP.NET Core ASP.NET Core - all versions feature
Projects
None yet
Milestone
NLog.Web.AspNetCore 4.5 + NLog.Web 4...
2 participants
@304NotModified @snakefoot