Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HSM 3: PKCS#11 walking skeleton #727

Merged
merged 153 commits into from
Nov 23, 2021
Merged

Commits on Sep 23, 2021

  1. Support multiple signers of different types behind a HSM feature flag…

    …, and support in principle selecting which signer to use for which purpose. (#539)
    ximon18 committed Sep 23, 2021
    Configuration menu
    Copy the full SHA
    5571271 View commit details
    Browse the repository at this point in the history
  2. Added some developer docs.

    ximon18 committed Sep 23, 2021
    Configuration menu
    Copy the full SHA
    1f2c9ee View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2021

  1. Configuration menu
    Copy the full SHA
    0fb9c91 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2021

  1. - Bump to v0.3.1 of the kmip-protocol crate.

    - Add a dependency on the backoff crate for retry support.
    - Add a dependency on the r2d2 crate for connection pooling support.
    - Uses GitHub versions of the bcder and rpki crates for the DER Unsigned Integer support needed by the KMIP signer.
    - Refactor signers to crypto::signers and replace the Dummy signer with a KMIP signer.
    - Added a "hsmtest" job to the GitHub Actions CI workflow that runs all Krill tests using the KMIP signer against PyKMIP.
    - Added a "hsm-tests" Cargo feature flag for configuring Krill to use ONLY KMIP as a signer, not OpenSSL at all.
      Currently building without the "hsm-tests" feature flag set will fail if the "hsm" feature flag is set.
      Krill isn't ready to be used in "hsm" mode yet.
    - Changes SignerProvider to implement the Signer trait so that it can be passed to builders so that their invocation of a signer also goes via SignerProvider dispatching to the correct signer.
    ximon18 committed Oct 5, 2021
    Configuration menu
    Copy the full SHA
    870a102 View commit details
    Browse the repository at this point in the history
  2. Avoid potential race conditions: Check for expected state, and retain…

    … the write lock while switching to using the server as part of finishing a successful probe.
    ximon18 committed Oct 5, 2021
    Configuration menu
    Copy the full SHA
    b849f66 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4e759aa View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    431b54d View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    9b788ae View commit details
    Browse the repository at this point in the history
  6. FIX: Signer dispatching must always be routed to the appropriate sign…

    …er. Previously some Krill logic when invoked was given the same signer as handling the current purpose to invoke later even if for a different purpose. If the initial purpose required the KMIP signer as the key owning signer but the later purpose was one-off signing then that should be able to be routed if desired to the OpenSslSigner, for example. Introduces another layer of indirection: RouterSigner.
    ximon18 committed Oct 5, 2021
    Configuration menu
    Copy the full SHA
    5322233 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    5e359b3 View commit details
    Browse the repository at this point in the history
  8. Remove commented out code.

    ximon18 committed Oct 5, 2021
    Configuration menu
    Copy the full SHA
    369d00a View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2021

  1. Remove unnecessary Arc<RwLock<..>> and naming cleanup.

    "router", not "dispatcher", and don't lock the entire SignerRouter for create/delete key operations.
    ximon18 authored Oct 6, 2021
    Configuration menu
    Copy the full SHA
    280ccc4 View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2021

  1. WIP: Add a SignerMapper that is used to map from KeyIdentifier to Sig…

    …ner and from KeyIdentifier to Signer specific key id. Stores mapping using a new SignerInfo AggregateStore impl backed by a 'signers' subdirectory of the Krill data dir.. Krill can now be built with the `hsm` feature active without also requiring the `hsm-tests` feature to be active. Needs code cleanup and tests and docs.
    ximon18 committed Oct 12, 2021
    Configuration menu
    Copy the full SHA
    f9d7c4f View commit details
    Browse the repository at this point in the history
  2. Test both in normal HSM usage mode (use OpenSSL for one-off keys) and…

    … in HSM test usage mode (use the HSM as much as possible).
    ximon18 committed Oct 12, 2021
    Configuration menu
    Copy the full SHA
    36b1dc7 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3c6907d View commit details
    Browse the repository at this point in the history
  4. (Temporary work around) Wait longer in the suspend test so that slowe…

    …r operation when using the PyKMIP signer instead of OpenSSL doesn't invoke refresh single too soon.
    ximon18 committed Oct 12, 2021
    Configuration menu
    Copy the full SHA
    29c07c8 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    af44866 View commit details
    Browse the repository at this point in the history
  6. Drop comments about signer identity verification, the functionality w…

    …asn't intended to securely guarantee that and other mechanisms for that exist such as TLS server certificate verification.
    ximon18 committed Oct 12, 2021
    Configuration menu
    Copy the full SHA
    f825f87 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    04ae949 View commit details
    Browse the repository at this point in the history
  8. Clippy.

    ximon18 committed Oct 12, 2021
    Configuration menu
    Copy the full SHA
    198dde6 View commit details
    Browse the repository at this point in the history
  9. Tweaked some comments.

    ximon18 committed Oct 12, 2021
    Configuration menu
    Copy the full SHA
    bb97234 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    512a477 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    e7a6a66 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2021

  1. Configuration menu
    Copy the full SHA
    f59431b View commit details
    Browse the repository at this point in the history
  2. cargo fmt.

    ximon18 committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    5b93ec7 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2021

  1. Lots of tweaks, depends on locally modified unreleased kmip-protocol …

    …crate version for new ItemNotFound suberror. Make the signer registration public key non-optional. Remove no longer used get_handle() signer fn. Deduplicate signers added to the pending set. Improvements to the binding process: bind by same name first, then try other signer store public keys; detect fatal failures and abort testing ready signers; detect key not found separately to other KMIP errors; cleanup the logic; don't panic if KMIP signer doesn't yet have a signer handle; just unwrap() locks consist with other Krill code.
    ximon18 committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    4f55ad1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3995b31 View commit details
    Browse the repository at this point in the history
  3. Use a local fork of rpki-rs which depends on bcder 0.6.1-dev instead …

    …of 0.6.0 so that Krill compiles.
    ximon18 committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    397e503 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    c68d50f View commit details
    Browse the repository at this point in the history
  5. More mut removal.

    ximon18 committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    866e71c View commit details
    Browse the repository at this point in the history
  6. More mut removal. Replace RwLocks around SignerProviders with a much …

    …tinier RwLock around the signer handle held by each SignerProvider.
    ximon18 committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    38fd8d1 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    502e10e View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2021

  1. Configuration menu
    Copy the full SHA
    c0cf4f9 View commit details
    Browse the repository at this point in the history
  2. Broken: cannot make KrillSigner async because CertAuth::process_comma…

    …nd() is an impl of a trait fn which is not supported.
    
    I also cannot further modify KrillSigner fns to use the new Sign and SignWithKey rpki-rs traits as SignedObjectBuilder::finalize() needs a Signer that we don't want to pass to it and it cannot be replicated as it uses rpki-rs private internals.
    ximon18 committed Oct 18, 2021
    Configuration menu
    Copy the full SHA
    0bb4300 View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2021

  1. Configuration menu
    Copy the full SHA
    a774c31 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0ce2af0 View commit details
    Browse the repository at this point in the history
  3. Rename SignerError::SignerUnavailable and SignerError::SignerUnusable…

    … to (a) drop the redundant Signer prefix in the variant name and (b) to indicate the duration/severity of the issue, particularly that Unavailable is a transient error as it is used to guide retry logic.
    ximon18 committed Oct 20, 2021
    Configuration menu
    Copy the full SHA
    e746119 View commit details
    Browse the repository at this point in the history
  4. Rename the flag for whether or not a KMIP signer has support for gene…

    …rating random numbers to something non-KMIP specific as the concept also applies to other signers and this will make code across signers more consistent and more amenable to factoring out later.
    ximon18 committed Oct 20, 2021
    Configuration menu
    Copy the full SHA
    29db34d View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    894cd29 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    930dbff View commit details
    Browse the repository at this point in the history
  7. Use the same arg name as the OpenSslSigner both because it better say…

    …s what it does and for consistency across signers.
    ximon18 committed Oct 20, 2021
    Configuration menu
    Copy the full SHA
    5bacab6 View commit details
    Browse the repository at this point in the history
  8. Extract getting the pool connection out to a helper fn in preparation…

    … for using some of the same logic/code in the PKCS#11 signer but without the pool. Hopefully later the common code can be factored out.
    ximon18 committed Oct 20, 2021
    Configuration menu
    Copy the full SHA
    055fd67 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    f2190b1 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    ede4dff View commit details
    Browse the repository at this point in the history
  11. WIP: Incomplete initial PKCS#11 functionality based on a mix of lates…

    …t KMIP code and prototype PKCS#11 code. Uses some of the ideas and code from the KMIP signer to prevent Krill startup blocking or failing if the PKCS#11 signer is unavailable or unusable and for retrying requests if the cause of failure appears to be transient. Also contains initial support for multiple active PKCS#11 signers using the same and/or different libraries (by filesystem path) unlike the prototype which could only load one library at a time. Configuration is hard-coded at present. Also unlike the prototype the Pkcs11Session type handles passing the session handle to the PKCS#11 library instead of requiring the caller to do so. Hopefully lots of code in common with KmipSigner can be factored out later.
    ximon18 committed Oct 20, 2021
    Configuration menu
    Copy the full SHA
    ac52c1c View commit details
    Browse the repository at this point in the history
  12. Removed unused trait impl.

    ximon18 committed Oct 20, 2021
    Configuration menu
    Copy the full SHA
    1864b85 View commit details
    Browse the repository at this point in the history
  13. WIP:

    - Log all Cryptoki calls at trace level and log all Cryptoki errors.
    - Implement all Signer functionality except random number generation and key deletion.
    - Wire up integration with the SignerMapper.
    - Correct KMIP copy-pasted references that should say PKCS#11.
    - Support locating theslot ID by label.
    - Support reporting Cryptoki and token details.
    - Support logging in (required to make many Cryptoki calls).
    ximon18 committed Oct 20, 2021
    Configuration menu
    Copy the full SHA
    4662b92 View commit details
    Browse the repository at this point in the history
  14. Use a second signer configuration (OpenSSL instead of PKCS#11) when c…

    …reating the second Alice publisher and for any other tests needing two signer different configurations (as configuration is hard-coded at present). Disable the migrate repository test which fails for a similar reason. This is all caused by SoftHSMv2 not supporting more than one user or that one user to be logged in more than once at a time. Cargo test --features hsm,hsm-tests-pkcs11 passes with these temporary hacks.
    ximon18 committed Oct 20, 2021
    Configuration menu
    Copy the full SHA
    b8930b2 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2021

  1. PKCS#11 updates:

    - Rename temporary second_signer_hack flag to alternate_config flag. Document the reason for the flag.
    - Added some code comments.
    - Support login without user pin.
    - Support token use without login.
    - Include signer name in log messages.
    - Dump full Cryptoki, slot and token info at trace level.
    ximon18 committed Oct 21, 2021
    Configuration menu
    Copy the full SHA
    d08e8cc View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8dfa760 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3d72fc8 View commit details
    Browse the repository at this point in the history
  4. More / tweaked comments.

    ximon18 committed Oct 21, 2021
    Configuration menu
    Copy the full SHA
    8dbc7b1 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2021

  1. Configuration menu
    Copy the full SHA
    a476c14 View commit details
    Browse the repository at this point in the history
  2. Factor out the KMIP/PKCS#11 common server probing code into a new pro…

    …be module with its own tests.
    ximon18 committed Oct 23, 2021
    Configuration menu
    Copy the full SHA
    a8155a7 View commit details
    Browse the repository at this point in the history
  3. Remove unused code.

    ximon18 committed Oct 23, 2021
    Configuration menu
    Copy the full SHA
    26bc03d View commit details
    Browse the repository at this point in the history
  4. Fix typo in comment.

    ximon18 committed Oct 23, 2021
    Configuration menu
    Copy the full SHA
    6c9f829 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    652297a View commit details
    Browse the repository at this point in the history
  6. cargo fmt

    ximon18 committed Oct 23, 2021
    Configuration menu
    Copy the full SHA
    3aaca1c View commit details
    Browse the repository at this point in the history
  7. Use published fork of rpki-rs instead of a local only copy so that GH…

    … Actions builds can compile.
    ximon18 committed Oct 23, 2021
    Configuration menu
    Copy the full SHA
    32ce607 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    8f5b4d4 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    a452c77 View commit details
    Browse the repository at this point in the history
  10. First attempt at a GitHub Actions CI job for testing the PKCS#11 supp…

    …ort against SoftHSMv2.
    ximon18 committed Oct 23, 2021
    Configuration menu
    Copy the full SHA
    ff3b18a View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    3a32923 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    31e9e64 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    b92d0fc View commit details
    Browse the repository at this point in the history
  14. Use published fork of rpki-rs instead of a local only copy so that GH…

    … Actions builds can compile.
    ximon18 committed Oct 23, 2021
    Configuration menu
    Copy the full SHA
    dcfe4e5 View commit details
    Browse the repository at this point in the history
  15. Revert "Broken: cannot make KrillSigner async because CertAuth::proce…

    …ss_command() is an impl of a trait fn which is not supported."
    
    This reverts commit 0bb4300.
    ximon18 committed Oct 23, 2021
    Configuration menu
    Copy the full SHA
    3becfdb View commit details
    Browse the repository at this point in the history
  16. Merge branch 'test-integration-of-rpki-rs-163-async-signing-of-reposi…

    …tory-objects' into issue-547-pkcs11-walking-skeleton
    ximon18 committed Oct 23, 2021
    Configuration menu
    Copy the full SHA
    aab3a20 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2021

  1. Configuration menu
    Copy the full SHA
    fd42610 View commit details
    Browse the repository at this point in the history
  2. Re-order some PKCS#11 signer functions for easier comparison with the…

    … other signer implementations.
    ximon18 committed Oct 24, 2021
    Configuration menu
    Copy the full SHA
    a0c2a99 View commit details
    Browse the repository at this point in the history
  3. Re-order some OpenSSL signer functions for easier comparison with the…

    … other signer implementations and remove unnecessary #[cfg(feature = "hsm")] guards.
    ximon18 committed Oct 24, 2021
    Configuration menu
    Copy the full SHA
    f49b712 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2021

  1. Configuration menu
    Copy the full SHA
    ce33dfe View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6789249 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ce41fd6 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2021

  1. Configuration menu
    Copy the full SHA
    7da0cdf View commit details
    Browse the repository at this point in the history
  2. Additional comments.

    ximon18 committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    c2627b6 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ca3ecab View commit details
    Browse the repository at this point in the history
  4. Add a mock signer in test builds only and a happy flow test which exe…

    …rcises registering and using it.
    ximon18 committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    6702aec View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2021

  1. Configuration menu
    Copy the full SHA
    23a19d2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    475f303 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c28e16e View commit details
    Browse the repository at this point in the history
  4. Use base64 encoding instead of hex for the signer identity public key…

    … to be more consistent with how other keys are stored by Krill.
    ximon18 committed Oct 27, 2021
    Configuration menu
    Copy the full SHA
    0aa287f View commit details
    Browse the repository at this point in the history
  5. Use UUIDs as signer handles, not combined KeyIdentifier+private inter…

    …nal key id, and store the signer identity details more explicitly in the SignerInfo.
    ximon18 committed Oct 27, 2021
    Configuration menu
    Copy the full SHA
    758248b View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    eadda4b View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    bf7aba1 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2021

  1. Configuration menu
    Copy the full SHA
    abb2a16 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b13ab67 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    aab013b View commit details
    Browse the repository at this point in the history
  4. cargo fmt.

    ximon18 committed Oct 28, 2021
    Configuration menu
    Copy the full SHA
    4e8f2ff View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    568cd27 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    abb0128 View commit details
    Browse the repository at this point in the history
  7. Correct some comments and add a test for registration of a temporaril…

    …y unavailable signer.
    ximon18 committed Oct 28, 2021
    Configuration menu
    Copy the full SHA
    4d5c2ab View commit details
    Browse the repository at this point in the history
  8. cargo fmt.

    ximon18 committed Oct 28, 2021
    Configuration menu
    Copy the full SHA
    7cdecae View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2021

  1. Disable compiler optimizations for the pkcs11 crate to workaround a `…

    …CKR_ARGUMENTS_BAD` error from SoftHSMv2 when calling `C_Initialize()` in a `--release` build with SoftHSMv2 logging "pReserved must be set to NULL_PTR".
    ximon18 committed Oct 30, 2021
    Configuration menu
    Copy the full SHA
    83a3bd1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2a0fe69 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e5fb41d View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    97791b5 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    1548efd View commit details
    Browse the repository at this point in the history
  6. Merge branch 'issue-566-implement-krill-kmip-based-signer-implementat…

    …ion' into hsm-persistent-signer-key-mappings
    ximon18 committed Oct 30, 2021
    Configuration menu
    Copy the full SHA
    bcc4d1b View commit details
    Browse the repository at this point in the history
  7. Merge branch 'hsm-persistent-signer-key-mappings' into test-integrati…

    …on-of-rpki-rs-163-async-signing-of-repository-objects
    ximon18 committed Oct 30, 2021
    Configuration menu
    Copy the full SHA
    9129caa View commit details
    Browse the repository at this point in the history
  8. Merge branch 'test-integration-of-rpki-rs-163-async-signing-of-reposi…

    …tory-objects' into issue-547-pkcs11-walking-skeleton
    ximon18 committed Oct 30, 2021
    Configuration menu
    Copy the full SHA
    495b324 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    d74521f View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2021

  1. Use machine architecture independent path for softhsm.so as it works …

    …on both Ubuntu and Alpine Linux (the latter is needed for running with softhsm in the e2e test).
    ximon18 committed Oct 31, 2021
    Configuration menu
    Copy the full SHA
    cc1a5da View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2021

  1. Configuration menu
    Copy the full SHA
    38c5b79 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    dd705df View commit details
    Browse the repository at this point in the history
  3. Merge branch 'issue-566-implement-krill-kmip-based-signer-implementat…

    …ion' into hsm-persistent-signer-key-mappings
    ximon18 committed Nov 1, 2021
    Configuration menu
    Copy the full SHA
    6356797 View commit details
    Browse the repository at this point in the history
  4. Merge branch 'hsm-persistent-signer-key-mappings' into test-integrati…

    …on-of-rpki-rs-163-async-signing-of-repository-objects
    ximon18 committed Nov 1, 2021
    Configuration menu
    Copy the full SHA
    82cf643 View commit details
    Browse the repository at this point in the history
  5. Merge branch 'issue-547-pkcs11-walking-skeleton' of github.com:NLnetL…

    …abs/krill into issue-547-pkcs11-walking-skeleton
    ximon18 committed Nov 1, 2021
    Configuration menu
    Copy the full SHA
    cbed508 View commit details
    Browse the repository at this point in the history
  6. Merge branch 'test-integration-of-rpki-rs-163-async-signing-of-reposi…

    …tory-objects' into issue-547-pkcs11-walking-skeleton
    ximon18 committed Nov 1, 2021
    Configuration menu
    Copy the full SHA
    36843b3 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    3c96561 View commit details
    Browse the repository at this point in the history
  8. Merge branch 'test-integration-of-rpki-rs-163-async-signing-of-reposi…

    …tory-objects' into issue-547-pkcs11-walking-skeleton
    ximon18 committed Nov 1, 2021
    Configuration menu
    Copy the full SHA
    25a6373 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2021

  1. Apply crate upgrade and signer 'de-mut' changes that were made in suc…

    …cessor PR #688 which is now redundant because those changes are now present in the 'dev' branch which this PR targets.
    ximon18 committed Nov 3, 2021
    Configuration menu
    Copy the full SHA
    3e6c0cb View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    90de083 View commit details
    Browse the repository at this point in the history
  3. Merge fix.

    ximon18 committed Nov 3, 2021
    Configuration menu
    Copy the full SHA
    00e93ce View commit details
    Browse the repository at this point in the history
  4. Apply crate upgrade and signer 'de-mut' changes that were made in suc…

    …cessor PR #688 which is now redundant because those changes are now present in the 'hsm-persistent-signer-key-mappings' branch which this PR targets.
    ximon18 committed Nov 3, 2021
    Configuration menu
    Copy the full SHA
    57ab685 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    80c0e32 View commit details
    Browse the repository at this point in the history
  6. Merge branch 'issue-566-implement-krill-kmip-based-signer-implementat…

    …ion' into hsm-persistent-signer-key-mappings
    ximon18 committed Nov 3, 2021
    Configuration menu
    Copy the full SHA
    9095794 View commit details
    Browse the repository at this point in the history
  7. Merge fix.

    ximon18 committed Nov 3, 2021
    Configuration menu
    Copy the full SHA
    34c8742 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    f9e3541 View commit details
    Browse the repository at this point in the history
  9. cargo fmt.

    ximon18 committed Nov 3, 2021
    Configuration menu
    Copy the full SHA
    dcde4dc View commit details
    Browse the repository at this point in the history
  10. Alias/wrap verbose types and don't fail if the PKCS#11 library can't …

    …be found or loaded as we shouldn't block Krill startup on signer failure.
    ximon18 committed Nov 3, 2021
    Configuration menu
    Copy the full SHA
    248caf7 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    4f7c24d View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    ef22a5c View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2021

  1. Configuration menu
    Copy the full SHA
    a1c39f7 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'issue-566-implement-krill-kmip-based-signer-implementat…

    …ion' into hsm-persistent-signer-key-mappings
    ximon18 committed Nov 9, 2021
    Configuration menu
    Copy the full SHA
    7421ebd View commit details
    Browse the repository at this point in the history
  3. Merge branch 'hsm-persistent-signer-key-mappings' of github.com:NLnet…

    …Labs/krill into hsm-persistent-signer-key-mappings
    ximon18 committed Nov 9, 2021
    Configuration menu
    Copy the full SHA
    4a424ee View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    9bcd929 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    e217717 View commit details
    Browse the repository at this point in the history
  6. Merge branch 'issue-566-implement-krill-kmip-based-signer-implementat…

    …ion' into hsm-persistent-signer-key-mappings
    ximon18 committed Nov 9, 2021
    Configuration menu
    Copy the full SHA
    964f03f View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    778ae64 View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2021

  1. Configuration menu
    Copy the full SHA
    5ceba33 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'issue-566-implement-krill-kmip-based-signer-implementat…

    …ion' into hsm-persistent-signer-key-mappings
    ximon18 committed Nov 10, 2021
    Configuration menu
    Copy the full SHA
    c0f1136 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3ad1106 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2021

  1. Configuration menu
    Copy the full SHA
    7feffe1 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2021

  1. Configuration menu
    Copy the full SHA
    40bafc3 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'issue-566-implement-krill-kmip-based-signer-implementat…

    …ion' into hsm-persistent-signer-key-mappings
    ximon18 committed Nov 15, 2021
    Configuration menu
    Copy the full SHA
    5a3fcad View commit details
    Browse the repository at this point in the history
  3. cargo fmt

    ximon18 committed Nov 15, 2021
    Configuration menu
    Copy the full SHA
    f69c53f View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    8e9cda8 View commit details
    Browse the repository at this point in the history
  5. Merge branch 'issue-566-implement-krill-kmip-based-signer-implementat…

    …ion' into hsm-persistent-signer-key-mappings
    ximon18 committed Nov 15, 2021
    Configuration menu
    Copy the full SHA
    073b843 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    19cede0 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    333ab6a View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    6f03e4d View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    d3aa487 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    94b8a7b View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2021

  1. Review feedback: merge Option<SlotId> and Option<SlotLabel> into new …

    …enum SlotIdOrLabel. Also refactor the `fn probe_server()` code where it is used into smaller private helper fns so that the main logic of the fn is easier to see. This also removes the need for the 'reacquisition' of the readale_ctx` which was a bit ugly.
    ximon18 committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    9a4a3b3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0daee00 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2021

  1. Review feedback: move signer.rs into internal.rs, and rename `_re…

    …move_key()` to `remove_key()` as it IS used by the RTA code. Also make key removal code more consistent across signer impls and always remove the key from the `SignerMapper` too.
    ximon18 committed Nov 18, 2021
    Configuration menu
    Copy the full SHA
    0027fb4 View commit details
    Browse the repository at this point in the history
  2. Review feedback: Don't keep a context object for a bad path. This was…

    … just a consequence of the the fact that the Rust std lib `fn HashMap::or_insert_with_key()` is infallible, but as we don't actually use the std lib impl we can change this behaviour.
    ximon18 committed Nov 18, 2021
    Configuration menu
    Copy the full SHA
    2ca582e View commit details
    Browse the repository at this point in the history
  3. cargo fmt

    ximon18 committed Nov 18, 2021
    Configuration menu
    Copy the full SHA
    905506e View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    5e9bc55 View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2021

  1. Configuration menu
    Copy the full SHA
    7bc195e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f054193 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7b97639 View commit details
    Browse the repository at this point in the history