Use new de-mut'd rpki-rs Signer trait. #688
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of 0.6.0 so that Krill compiles.
…tinier RwLock around the signer handle held by each SignerProvider.
…nd() is an impl of a trait fn which is not supported. I also cannot further modify KrillSigner fns to use the new Sign and SignWithKey rpki-rs traits as SignedObjectBuilder::finalize() needs a Signer that we don't want to pass to it and it cannot be replicated as it uses rpki-rs private internals.
… Actions builds can compile.
…ss_command() is an impl of a trait fn which is not supported." This reverts commit 0bb4300.
…on-of-rpki-rs-163-async-signing-of-repository-objects
…on-of-rpki-rs-163-async-signing-of-repository-objects
ximon18
added a commit
that referenced
this pull request
Nov 3, 2021
…cessor PR #688 which is now redundant because those changes are now present in the 'dev' branch which this PR targets.
ximon18
added a commit
that referenced
this pull request
Nov 3, 2021
…cessor PR #688 which is now redundant because those changes are now present in the 'hsm-persistent-signer-key-mappings' branch which this PR targets.
|
This PR is now redundant as the changes it introduced have been introduced via PR #702 into the upstream branches of this branch. |
ximon18
deleted the
test-integration-of-rpki-rs-163-async-signing-of-repository-objects
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on #686 "HSM persistent signer key mappings". Uses a fork of the
rpki-rscratereverse-signerbranch as I need it to depend on bcder 0.6.1-dev for my Krill branch to compile. I want to use the de-mut'd Signer trait change from the new rpki-rs crate version, when it gets released at some point, as it removes a lot of boiler plate and unnecessary locking from my multi-signer code.Update: This PR has been updated to use the new official releases of the
bcderandrpki-rscrates rather than personal forks.