Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retain failed transfers for 12 weeks / 84 days #1025

Merged
merged 4 commits into from
Dec 6, 2024
Merged

Retain failed transfers for 12 weeks / 84 days #1025

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9d18331
Retain failed transfers for 12 weeks / 84 days
stevenmccullaghmadetech Dec 5, 2024
3f6333d
Changing 84 Days to 12 Weeks to better reflect wording in the spec.
stevenmccullaghmadetech Dec 5, 2024
c51667b
Reverting to P84D due to test failures.
stevenmccullaghmadetech Dec 6, 2024
2efd4f1
Updated language to fairly reflect both the spec, and our implementat…
stevenmccullaghmadetech Dec 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
## [Unreleased]

### Added
* When a transfer fails, the transfer should remain available in the db for at least 12 weeks, as per spec.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd propose to change the description to 84 days (e.g. "at least 84 days, as per spec") to be consistent with the TTL format (P84D). This way it will be less confusing for the users of the adaptor.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see what you mean, but I also want to reflect what's said in the spec. So I'm changing it to:
"When a transfer fails, the transfer should remain available in the db for at least 12 weeks (84 days), as per spec."
I think this helps to clarify for both spec and devs.

* When mapping a `DocumentReference` which contains a `NOPAT` `meta.security` or `NOPAT` `securityLabel` tag the resultant XML for that resource
will contain a `NOPAT` `confidentialityCode` element.
* When mapping `AllergyIntolerances` which contain a `NOPAT` `meta.security` tag the resultant XML for that resource
Expand Down
4 changes: 2 additions & 2 deletions OPERATING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ The adaptor requires a Mongodb-compatible database to manage its internal state.
| GP2GP_MONGO_PASSWORD | | Mongo database password. Leave undefined if GP2GP_MONGO_URI is used. |
| GP2GP_MONGO_OPTIONS | | Mongodb URL encoded parameters for the connection string without a leading "?". Leave undefined if GP2GP_MONGO_URI is used. |
| GP2GP_MONGO_AUTO_INDEX_CREATION | true | (Optional) Should auto index for Mongo database be created. |
| GP2GP_MONGO_TTL | P7D | (Optional) Time-to-live value for inbound and outbound state collection documents as an [ISO 8601 Duration](https://en.wikipedia.org/wiki/ISO_8601#Durations). |
| GP2GP_MONGO_TTL | P84D | (Optional) Time-to-live value for inbound and outbound state collection documents as an [ISO 8601 Duration](https://en.wikipedia.org/wiki/ISO_8601#Durations). |
| GP2GP_COSMOS_DB_ENABLED | false | (Optional) If true the adaptor will enable features and workarounds to support Azure Cosmos DB. |

**Trust Store Configuration Options**
Expand Down Expand Up @@ -266,7 +266,7 @@ The adaptor's database records:
* metadata about the transfer process

The supplier MUST configure the `GP2GP_MONGO_TTL` variable to remove the database records
after a reasonable time period.
after a reasonable time period. The specs say 12 weeks, so this is our suggestion.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd propose to change the description to 84 days (e.g. "The specs say 84 days...") to be consistent with the TTL format (P84D). This way it will be less confusing for the users of the adaptor.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same.


The adaptor's queued messages contain:
* the patient's NHS number
Expand Down
2 changes: 1 addition & 1 deletion service/src/intTest/resources/application.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ gp2gp:
password: ${GP2GP_MONGO_PASSWORD:}
options: ${GP2GP_MONGO_OPTIONS:}
autoIndexCreation: ${GP2GP_MONGO_AUTO_INDEX_CREATION:true}
ttl: ${GP2GP_MONGO_TTL:P7D}
ttl: ${GP2GP_MONGO_TTL:P84D}
cosmosDbEnabled: ${GP2GP_COSMOS_DB_ENABLED:false}
gpc:
url: ${GP2GP_GPC_GET_URL:http://localhost:8090/@ODS_CODE@/STU3/1/gpconnect}
Expand Down
2 changes: 1 addition & 1 deletion service/src/main/resources/application.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ gp2gp:
password: ${GP2GP_MONGO_PASSWORD:}
options: ${GP2GP_MONGO_OPTIONS:}
autoIndexCreation: ${GP2GP_MONGO_AUTO_INDEX_CREATION:true}
ttl: ${GP2GP_MONGO_TTL:P7D}
ttl: ${GP2GP_MONGO_TTL:P84D}
cosmosDbEnabled: ${GP2GP_COSMOS_DB_ENABLED:false}
gpc:
url: ${GP2GP_GPC_GET_URL:http://localhost:8090/@ODS_CODE@/STU3/1/gpconnect}
Expand Down
Loading