Retain failed transfers for 12 weeks / 84 days #1025
Conversation
CHANGELOG.md
Outdated
| @@ -7,6 +7,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
| ## [Unreleased] | |||
|
|
|||
| ### Added | |||
| * When a transfer fails, the transfer should remain available in the db for at least 12 weeks, as per spec. | |||
There was a problem hiding this comment.
I'd propose to change the description to 84 days (e.g. "at least 84 days, as per spec") to be consistent with the TTL format (P84D). This way it will be less confusing for the users of the adaptor.
There was a problem hiding this comment.
I see what you mean, but I also want to reflect what's said in the spec. So I'm changing it to:
"When a transfer fails, the transfer should remain available in the db for at least 12 weeks (84 days), as per spec."
I think this helps to clarify for both spec and devs.
OPERATING.md
Outdated
| @@ -266,7 +266,7 @@ The adaptor's database records: | |||
| * metadata about the transfer process | |||
|
|
|||
| The supplier MUST configure the `GP2GP_MONGO_TTL` variable to remove the database records | |||
| after a reasonable time period. | |||
| after a reasonable time period. The specs say 12 weeks, so this is our suggestion. | |||
There was a problem hiding this comment.
I'd propose to change the description to 84 days (e.g. "The specs say 84 days...") to be consistent with the TTL format (P84D). This way it will be less confusing for the users of the adaptor.
There was a problem hiding this comment.
Same.
|
Looks good. No mutations were possible for these changes. |
|
What
Retain failed transfers for 12 weeks / 84 days as per spec.
Why
Required by specifications. Facilitates data retention and the ability to initiate a retry.
Type of change
Please delete options that are not relevant.
Checklist: