-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AEA-3612 Copy getSecrets layer to seperate repo #1
Merged
anthony-nhs
merged 33 commits into
main
from
AEA-3612-copy-getSecrets-layer-to-seperate-repo
Nov 29, 2023
Merged
AEA-3612 Copy getSecrets layer to seperate repo #1
anthony-nhs
merged 33 commits into
main
from
AEA-3612-copy-getSecrets-layer-to-seperate-repo
Nov 29, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthony-nhs
reviewed
Nov 28, 2023
anthony-nhs
reviewed
Nov 29, 2023
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
anthony-nhs
approved these changes
Nov 29, 2023
anthony-nhs
deleted the
AEA-3612-copy-getSecrets-layer-to-seperate-repo
branch
November 29, 2023 10:01
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
📝 Summary:
The proposed changes to move the lambda layer for processing secrets to a separate repository and publishing it as a release artifact for the tracker API will have a significant business impact. This modification ensures a more modular and scalable architecture, allowing for independent updates and version control, thereby enhancing the maintainability and flexibility of the system. It also facilitates the seamless upgrade of the secret processing functionality for the tracker API without disrupting other components, streamlining development and deployment processes.
🎫 Jira Reference: https://nhsd-jira.digital.nhs.uk/browse/AEA-3612