-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(module:modal): draggable #8419
feat(module:modal): draggable #8419
Conversation
This preview will be available after the AzureCI is passed. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8419 +/- ##
==========================================
+ Coverage 91.61% 91.64% +0.02%
==========================================
Files 519 519
Lines 18076 18122 +46
Branches 2848 2769 -79
==========================================
+ Hits 16561 16607 +46
- Misses 1216 1217 +1
+ Partials 299 298 -1 ☔ View full report in Codecov by Sentry. |
That's awesome! I was literally thinking today users would benefit from being able to move a modal dialog. |
Btw, someone else had attempted at this a while back: #7852 Hopefully this one gets merged. |
@ParsaArvanehPA does it make sense for the automation to still assign @hsuanxyz as reviewer? Seems like he's not involved anymore. |
Thanks :)) |
Assigneess are automatically assigned based on this file (I think). I don't know if they are still involved or not. But other collabrators will check this PR nonetheless. |
@@ -49,7 +53,7 @@ import { ModalOptions } from './modal-types'; | |||
<button nz-modal-close (click)="onCloseClick()"></button> | |||
} | |||
@if (config.nzTitle) { | |||
<div nz-modal-title></div> | |||
<div nz-modal-title cdkDragHandle [style.cursor]="config.nzDraggable ? 'move' : 'default'"></div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change default
to auto
.
@HyperLife1119 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks guys for the fast merge, appreciate! |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Ng-zorro's Modal component lacks the draggable feature that Ant designs' modal provides.
What is the new behavior?
Now supports draggable modals
Does this PR introduce a breaking change?
Other information