Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:modal): support dragging (#7389) #7852

Closed
wants to merge 5 commits into from

Conversation

ZENETOM
Copy link

@ZENETOM ZENETOM commented Feb 26, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Feb 26, 2023

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Feb 26, 2023

Codecov Report

Merging #7852 (c7eef56) into master (e95cdb6) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head c7eef56 differs from pull request most recent head 4dd187b. Consider uploading reports for the commit 4dd187b to get more accurate results

@@            Coverage Diff             @@
##           master    #7852      +/-   ##
==========================================
+ Coverage   92.09%   92.10%   +0.01%     
==========================================
  Files         502      502              
  Lines       16819    16821       +2     
  Branches     2577     2662      +85     
==========================================
+ Hits        15489    15493       +4     
+ Misses       1059     1056       -3     
- Partials      271      272       +1     
Impacted Files Coverage Δ
components/modal/modal-container.component.ts 100.00% <ø> (ø)
components/modal/modal.module.ts 100.00% <ø> (ø)
components/modal/utils.ts 100.00% <ø> (ø)
components/modal/modal-types.ts 100.00% <100.00%> (ø)
components/modal/modal.component.ts 95.87% <100.00%> (+0.04%) ⬆️
components/tabs/tab-add-button.component.ts 75.00% <0.00%> (-25.00%) ⬇️
components/tabs/tab-nav-bar.component.ts 87.94% <0.00%> (+1.41%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ZENETOM ZENETOM marked this pull request as draft March 16, 2023 05:20
@ZENETOM ZENETOM marked this pull request as ready for review March 16, 2023 05:21
@HyperLife1119
Copy link
Collaborator

Thanks for the contribution, the modal component has just gotten drag and drop support via #8419, I will close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants