feat(module:modal): support draggable modal #4978
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4978 +/- ##
==========================================
+ Coverage 91.26% 91.28% +0.01%
==========================================
Files 535 535
Lines 13709 13734 +25
Branches 2040 2045 +5
==========================================
+ Hits 12512 12537 +25
+ Misses 731 730 -1
- Partials 466 467 +1
Continue to review full report at Codecov.
|
test(module:modal): add draggable test case close NG-ZORRO#4549, cc NG-ZORRO#2705, NG-ZORRO#1904, NG-ZORRO#120
hsuanxyz
force-pushed
the
feat/modal-draggable
branch
from
6269f8c
to
6ed0207
Compare
|
This preview will be available after the AzureCI is passed. |
|
Confirm 这种简单样式的 modal 应该需要改变鼠标样式。 遮罩顺序有点问题，弹出新 modal 之前最后一个被拖拽的 modal 也会在 backdrop 之上。
|
|
@wendellhu95 DEMO 里面有对应代码，现在 modal 不处理这些，只管挂载拖拽节点 |
vthinkxie
reviewed
Apr 13, 2020
| selector: 'nz-demo-modal-draggable', | ||
| template: ` | ||
| <button nz-button [nzType]="'primary'" (click)="showModal()">Show Modal</button> | ||
| |
There was a problem hiding this comment.
Suggested change
| |
should not including   in demo
|
Hope this PR will be merged ASAP. |
|
希望尽快merge |
|
need feature |
|
@hsuanxyz @hullis is there a reason why this PR is not yet merged? |
kunwp1
added a commit
to Texera/texera
that referenced
this pull request
Oct 3, 2023
This PR adds a new feature that allows users to drag the visualization operator window. Since the Ng Zorro Antd library does not support draggable modals natively ([as noted here](NG-ZORRO/ng-zorro-antd#4978)), I used a third-party library called `cdkDrag` to enable dragging the window.  --------- Co-authored-by: Xinyuan Lin <[email protected]>
|
Close via #8419. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test(module:modal): add draggable test case
close #4549, cc #2705, #1904, #120
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #4549, #2705, #1904, #120
What is the new behavior?
Does this PR introduce a breaking change?
Other information