Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cache-api instead of QueryAPI for Proposals and Rfp's #982

Merged

Conversation

Tguntenaar
Copy link
Collaborator

@Tguntenaar Tguntenaar commented Nov 6, 2024

Resolves #968
Resolves #987

This PR replaces all instances where we call the near-queryapi for proposals and rfps in events committee, infra and devhub.

As it is a sub issue of the 🔷 EPIC: Replace Indexer.

It does not include the snapshot logging between all relationship changes of proposals and rfp's YET. That is on purpose.

Skipping discussions test

I've updated this PR to intentionally skip the failing test due to RPC timeouts. I created a bug issue #991 to track the problem and temporarily disabled the test to unblock the pipeline. A note referencing the issue has been added in the source code. The impact of losing test coverage is minimal, as we are considering removing communities from the platform entirely.

@Tguntenaar Tguntenaar marked this pull request as ready for review November 15, 2024 06:07
@Tguntenaar
Copy link
Collaborator Author

@Megha-Dev-19 we need to fix some of the tests and then this issues is finished.

@Tguntenaar
Copy link
Collaborator Author

@race-of-sloths include

@race-of-sloths
Copy link

race-of-sloths commented Nov 15, 2024

@Tguntenaar Thank you for your contribution! Your pull request is now a part of the Race of Sloths!

Shows inviting banner with latest news.

Shows profile picture for the author of the PR

Current status: executed
Reviewer Score
@petersalomonsen 13

Your contribution is much appreciated with a final score of 13!
You have received 150 (130 base + 20 monthly bonus) Sloth points for this contribution

@petersalomonsen received 25 Sloth Points for reviewing and scoring this pull request.

Congratulations @Tguntenaar! Your PR was highly scored and you completed another monthly streak! To keep your monthly streak make another pull request next month and get 8+ score for it

What is the Race of Sloths

Race of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow

For contributors:

  • Tag @race-of-sloths inside your pull requests
  • Wait for the maintainer to review and score your pull request
  • Check out your position in the Leaderboard
  • Keep weekly and monthly streaks to reach higher positions
  • Boast your contributions with a dynamic picture of your Profile

For maintainers:

  • Score pull requests that participate in the Race of Sloths and receive a reward
  • Engage contributors with fair scoring and fast responses so they keep their streaks
  • Promote the Race to the point where the Race starts promoting you
  • Grow the community of your contributors

Feel free to check our website for additional details!

Bot commands
  • For contributors
    • Include a PR: @race-of-sloths include to enter the Race with your PR
  • For maintainers:
    • Invite contributor @race-of-sloths invite to invite the contributor to participate in a race or include it, if it's already a runner.
    • Assign points: @race-of-sloths score [1/2/3/5/8/13] to award points based on your assessment.
    • Reject this PR: @race-of-sloths exclude to send this PR back to the drawing board.
    • Exclude repo: @race-of-sloths pause to stop bot activity in this repo until @race-of-sloths unpause command is called

@Tguntenaar Tguntenaar changed the title Fetch from devhub-cache-api-rs.fly.dev Use cache-api instead of QueryAPI for Proposals and Rfp's Nov 21, 2024
…2. passing instance down to simplemde, 3. mock the test on the right api path.
Copy link
Collaborator Author

@Tguntenaar Tguntenaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to review

@petersalomonsen
Copy link
Collaborator

@race-of-sloths score 13

@petersalomonsen
Copy link
Collaborator

I looked at it again, and I can't find anything. I hope our test-coverage is sufficient to ensure that critical functionality is not broken. Will you do a manual check of the functionality in all 3 instances after you've merged @Tguntenaar ?

@Tguntenaar Tguntenaar merged commit 2878cca into NEAR-DevHub:main Nov 26, 2024
15 checks passed
@Tguntenaar
Copy link
Collaborator Author

@petersalomonsen I will do the manual check right now 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rewrite Front-End Tests to mock the New API Replace any part of the front end that uses the NEAR Query API
3 participants