-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use cache-api instead of QueryAPI for Proposals and Rfp's #982
Use cache-api instead of QueryAPI for Proposals and Rfp's #982
Conversation
@Megha-Dev-19 we need to fix some of the tests and then this issues is finished. |
@race-of-sloths include |
@Tguntenaar Thank you for your contribution! Your pull request is now a part of the Race of Sloths! Current status: executed
Your contribution is much appreciated with a final score of 13! @petersalomonsen received 25 Sloth Points for reviewing and scoring this pull request. Congratulations @Tguntenaar! Your PR was highly scored and you completed another monthly streak! To keep your monthly streak make another pull request next month and get 8+ score for it What is the Race of SlothsRace of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow For contributors:
For maintainers:
Feel free to check our website for additional details! Bot commands
|
…remove fetchgraphql from common
…2. passing instance down to simplemde, 3. mock the test on the right api path.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ready to review
@race-of-sloths score 13 |
I looked at it again, and I can't find anything. I hope our test-coverage is sufficient to ensure that critical functionality is not broken. Will you do a manual check of the functionality in all 3 instances after you've merged @Tguntenaar ? |
@petersalomonsen I will do the manual check right now 👍🏻 |
…)" This reverts commit 2878cca.
Resolves #968
Resolves #987
This PR replaces all instances where we call the near-queryapi for proposals and rfps in events committee, infra and devhub.
As it is a sub issue of the 🔷 EPIC: Replace Indexer.
It does not include the snapshot logging between all relationship changes of proposals and rfp's YET. That is on purpose.
Skipping discussions test
I've updated this PR to intentionally skip the failing test due to RPC timeouts. I created a bug issue #991 to track the problem and temporarily disabled the test to unblock the pipeline. A note referencing the issue has been added in the source code. The impact of losing test coverage is minimal, as we are considering removing communities from the platform entirely.