Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add discussions test back in with a fix for the RPC timeouts #991

Closed
Tguntenaar opened this issue Nov 23, 2024 · 1 comment
Closed

Add discussions test back in with a fix for the RPC timeouts #991

Tguntenaar opened this issue Nov 23, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@Tguntenaar
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
The discussions test is currently failing due to RPC timeouts when accessing both https://free.rpc.fastnear.com and https://rpc.mainnet.near.org. These RPC endpoints do not fetch data older than a certain timestamp. The test was functional until now because the queried transaction was within the supported timeframe. However, as the transaction aged, the test started failing. To address this, we need to use an archival RPC, which supports querying historical data.

Describe the solution you'd like

  • Switch to an archival RPC (https://archival-rpc.mainnet.near.org) to ensure historical data can be queried reliably.
  • Revisit the design and usage of the API proxy for tests to ensure stability, especially for local development and widget-related features like the "Don't ask again" checkbox.

Describe alternatives you've considered

  1. Modify the test to use an archival RPC endpoint (ARCHIVAL_RPC_URL).
  2. Use a local proxy solution for archival RPC requests (MOCK_ARCHIVAL_RPC_URL).

Additional context

  • The RPC proxy is used to serve widgets locally, ensuring features like the "Don't ask again" checkbox appear in the transaction confirmation modal. Standard BOS-workspace setups lack this feature without the proxy.
  • Switching to archival RPCs is necessary to handle the historical data required by this test.
@Tguntenaar
Copy link
Collaborator Author

Since we decided to remove announcements and discussions we will not need this test anymore so I will close the issue and add this info to 988.

@github-project-automation github-project-automation bot moved this from 🆕 Triage to ✅ Done in 🚀 DevHub Products Dec 7, 2024
@Tguntenaar Tguntenaar self-assigned this Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

1 participant